Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dispute escalated event #33

Merged
merged 3 commits into from
Sep 4, 2024
Merged

feat: dispute escalated event #33

merged 3 commits into from
Sep 4, 2024

Conversation

0xyaco
Copy link
Collaborator

@0xyaco 0xyaco commented Sep 3, 2024

🤖 Linear

Closes GRT-118

Description

Uses DisputeEscalated event as there's no DisputeStatusChanged event emitted from Prophet when escalating a dispute. This has already been reported but due to audits changing Prophet's code to emit the DisputeStatusChanged event while escalating a dispute too is not feasible.

Copy link

linear bot commented Sep 3, 2024

GRT-118 Handle DisputeEscalated event instead of DisputeStatusUpdate

Right now, the Prophet's Oracle contract does not emit a DisputeStatusUpdate during a ResponseDisputed and DisputeEscalated.

The ResponseDisputed event is already handled.

We are waiting on the onchain team's input to see if it's possible to always emit a DisputeStatusUpdate but in the meantime, the DisputeEscalated should be handled with the same logic that we are using while handling DisputeStatusUpdate with a status set to Escalated.

AC:

  • The EboActor reacts to the DisputeEscalated Oracle's event instead of the DisputeStatusUpdate(status: Escalated)

@0xyaco 0xyaco changed the title Feat/dispute escalated event feat: dispute escalated event Sep 3, 2024
@0xyaco 0xyaco changed the base branch from dev to feat/registry-commands September 3, 2024 21:29
@0xyaco 0xyaco force-pushed the feat/dispute-escalated-event branch from b713892 to 8386c8d Compare September 3, 2024 21:30
@0xyaco 0xyaco requested review from 0xkenj1 and 0xnigir1 September 3, 2024 21:37
0xnigir1
0xnigir1 previously approved these changes Sep 4, 2024
0xkenj1
0xkenj1 previously approved these changes Sep 4, 2024
Copy link
Collaborator

@0xkenj1 0xkenj1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Base automatically changed from feat/registry-commands to dev September 4, 2024 17:56
@0xyaco 0xyaco dismissed stale reviews from 0xkenj1 and 0xnigir1 September 4, 2024 17:56

The base branch was changed.

@0xyaco 0xyaco requested review from 0xkenj1 and 0xnigir1 September 4, 2024 18:03
@0xyaco 0xyaco merged commit 3733332 into dev Sep 4, 2024
5 checks passed
@0xyaco 0xyaco deleted the feat/dispute-escalated-event branch September 4, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants