-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement get events #50
Merged
Merged
Changes from 3 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
09ec614
feat: initial getEvents and errors and tests
jahabeebs 3858030
feat: type fixes
jahabeebs d845dd9
fix: more type fixes
jahabeebs 5f946da
feat: refactor event types
jahabeebs 9effca9
fix: remove nullish
jahabeebs fd5a1f1
fix: remove nullish
jahabeebs 5344f9c
feat: fix merge conflicts and types and tests
jahabeebs e0d11c0
fix: lint
jahabeebs ecf15f5
fix: address PR comments
jahabeebs cad9ae6
Merge branch 'dev' into feat/grt-143-implement-getEvents
jahabeebs 10aba16
chore: sync with dev
jahabeebs 4e39307
Merge remote-tracking branch 'origin/dev' into feat/grt-143-implement…
jahabeebs eb2d090
Merge branch 'dev' into feat/grt-143-implement-getEvents
jahabeebs 77ada49
feat: refactor DecodedLogArgsMap to type and fallthrough switch
jahabeebs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
7 changes: 7 additions & 0 deletions
7
packages/automated-dispute/src/exceptions/decodeLogDataFailure.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
export class DecodeLogDataFailure extends Error { | ||
constructor(err: unknown) { | ||
super(`Error decoding log data: ${err}`); | ||
|
||
this.name = "DecodeLogDataFailure"; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 6 additions & 0 deletions
6
packages/automated-dispute/src/exceptions/unsupportedEvent.exception.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
export class UnsupportedEvent extends Error { | ||
constructor(message: string) { | ||
super(message); | ||
this.name = "UnsupportedEvent"; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this approach, @0xkenj1 what do you think? Should we use this to define events' types instead of our current approach?
One way or another, we need to use a single approach as right now we have events' internal data types defined here and also defined in
types/events.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Matt says this: https://www.totaltypescript.com/type-vs-interface-which-should-you-use
tldr;
type
by default, go for interfaces if you expect to do inheritance