feat: add horizon accounting extension logic #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xyaco
reviewed
Sep 27, 2024
| @@ -43,6 +43,7 @@ const protocolProviderConfigSchema = z.object({ | |||
| epochManager: addressSchema, | |||
| eboRequestCreator: addressSchema, | |||
| bondEscalationModule: addressSchema, | |||
| horizonAccountingExtension: addressSchema, | |||
There was a problem hiding this comment.
Oh nice!
Mind adding an example address for this new field in apps/agent/config.example.yml?
Comment on lines
348
to
350
| } catch (error) { | ||
| throw error; | ||
| } |
There was a problem hiding this comment.
Do we want to catch the error and just re-throw it? Could we skip the catch?
There was a problem hiding this comment.
we can just skip the catch, I was just re-throwing because we were re-throwing in other methods in protocolProvider but we can just leave it out since eboActor will handle
| try { | ||
| const approvedModules = | ||
| await this.horizonAccountingExtensionContract.read.approvedModules([user]); | ||
| return approvedModules.slice(); |
There was a problem hiding this comment.
This would be the same as [...approvedModules] right?
There was a problem hiding this comment.
yep refactored to be more concise
Comment on lines
364
to
366
| } catch (error) { | ||
| throw error; | ||
| } |
There was a problem hiding this comment.
Same catch-throw comment as before
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Linear
Closes GRT-164
Description
Note that with the new error handling strategy we are just throwing the error if the transaction does not revert and we are not doing the .walk logic that we previously did with errors in ProtocolProvider