docs: create README for shared package #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xnigir1
reviewed
Oct 17, 2024
packages/shared/src/external.ts
Outdated
Comment on lines
2
to
3
| export { HexUtils as AddressUtils, Caip2Utils, Logger } from "./services/index.js"; | ||
| export { InvalidHex as InvalidAddress, InvalidChainId } from "./exceptions/index.js"; |
There was a problem hiding this comment.
are these X as Y correct? i see that in the other packages you're using HexUtils, not AddressUtils
There was a problem hiding this comment.
Whoops, refactoring made wrong
packages/shared/README.md
Outdated
There was a problem hiding this comment.
I'm just standing on the shoulders of READMEs/repo boilerplate giants
0xnigir1
approved these changes
Oct 17, 2024
jahabeebs
approved these changes
Oct 17, 2024
| @@ -0,0 +1,68 @@ | |||
| # ebo-agent: shared package | |||
|
|
|||
| Shared lib that for EBO agent libraries. | |||
There was a problem hiding this comment.
*Shared lib for EBO agent libraries
There was a problem hiding this comment.
Oooh nice catch! 🔭 I'll fix it in the next docs PR
0xkenj1
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Linear
Closes GRT-218
Description
sharedpackageAddressservice toHexUtilsNormalizedAddresstype toNormalizedHex