fix: handle DisputeEscalated events for not first disputes #81
Conversation
| import { CommandAlreadyRun, CommandNotRun } from "../../../exceptions/index.js"; | ||
| import { EboRegistryCommand } from "../../../interfaces/index.js"; | ||
|
|
||
| export class NoOp implements EboRegistryCommand { |
There was a problem hiding this comment.
Might be good to have some docs in this class as I'm curious what you mean by noop in this context---I know that it means "do nothing" usually but why it's not immediately clear to me why we need the build() command. Also, do you think we need some logging in build() would be useful for when it's invoked in ResponseDisputed so we know when a new noop instance is returned?
There was a problem hiding this comment.
We could technically make the constructor public and use new NoOp(); I wanted to keep the same approach the other commands are using, just for the sake of things consistent.
Seems like a wise decision to log the no-op "execution", I agree!
|
|
||
| blockNumberService: | ||
| blockmetaConfig: | ||
| baseUrl: "localhost:443" |
There was a problem hiding this comment.
just a double check that it's the correct port since its HTTPS one
There was a problem hiding this comment.
It's kinda a placeholder for Tenderly config tbh, we are not indexing any chain that needs the blockmeta service.
0xyaco
dismissed stale reviews from 0xnigir1 and jahabeebs
The base branch was changed.
🤖 Linear
Closes GRT-241
Description
Prophet can emit a
DisputeEscalatedevent prior theResponseDisputedevent, causing issues in actors' event processing.Fix this special case by handling events being emitted in this particular order.