feat: validate horizon staking authorization during agent bootup #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dress-to-config' into feat/grt-230-update-rpc-abis-and-behavior
…eat/grt-230-update-rpc-abis-and-behavior
…-behavior' into feat/grt-230-update-rpc-abis-and-behavior
jahabeebs
changed the base branch from
dev
to
feat/grt-230-update-rpc-abis-and-behavior
0xyaco
previously approved these changes
Nov 22, 2024
apps/agent/config.tenderly.yml
Outdated
| @@ -16,6 +16,7 @@ protocolProvider: | |||
| eboRequestCreator: "0xa13318684281a820304C164427396385C306d870" | |||
| bondEscalationModule: "0x52d7728fE87826FfF51b21b303e2FF7cB04F6Aec" | |||
| horizonAccountingExtension: "0xbDAB27D1903da4e18B0D1BE873E18924514E52eC" | |||
| horizonStaking: "0x1234567890123456789012345678901234567890" # TODO: Update address | |||
There was a problem hiding this comment.
This address should be fine for the moment (Sepolia's Horizon Staking contract address):
0x3F53F9f9a5d7F36dCC869f8D2F227499c411c0cf
0xnigir1
reviewed
Nov 22, 2024
| @@ -42,6 +42,7 @@ const contractsAddressesSchema = z.object({ | |||
| horizonAccountingExtension: hexSchema | |||
| .optional() | |||
| .default("0x0000000000000000000000000000000000000000"), | |||
| horizonStaking: hexSchema, | |||
There was a problem hiding this comment.
why we use hexSchema here but on config we use addressSchema?
There was a problem hiding this comment.
you're right, I ended up changing hexSchema to addressSchema. However I don't want to abstract out the zod types to the shared package or create a circular dependency so I have a duplicate addressSchema for these two packages for now
Comment on lines
1250
to
1255
| const authorized = await this.horizonStakingContract.read.isAuthorized([ | ||
| serviceProvider, | ||
| verifier, | ||
| operator, | ||
| ]); | ||
| return authorized; |
There was a problem hiding this comment.
Suggested change
| const authorized = await this.horizonStakingContract.read.isAuthorized([ | |
| serviceProvider, | |
| verifier, | |
| operator, | |
| ]); | |
| return authorized; | |
| return this.horizonStakingContract.read.isAuthorized([ | |
| serviceProvider, | |
| verifier, | |
| operator, | |
| ]); |
picky here 😆 but given that you only return the result without logging or try/catch block
| if (!isAuth) { | ||
| const errorMessage = `Authorization required: Operator ${operator} is not authorized for service provider ${serviceProvider}.`; | ||
| this.logger.error(errorMessage); | ||
| process.exit(1); |
There was a problem hiding this comment.
just double checking that we want to exit the process right away
Base automatically changed from
feat/grt-230-update-rpc-abis-and-behavior
to
dev
November 22, 2024 17:58
…zon-auth-during-bootup # Conflicts: # apps/agent/config.example.yml # packages/automated-dispute/src/providers/protocolProvider.ts # packages/automated-dispute/tests/services/protocolProvider.spec.ts
0xyaco
reviewed
Nov 25, 2024
|
|
||
| describe("start", () => { |
There was a problem hiding this comment.
Why was this describe deleted? 🤔
0xnigir1
previously approved these changes
Nov 25, 2024
0xyaco
approved these changes
Nov 25, 2024
0xnigir1
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Linear
Closes GRT-231
Description