feat: logic for new config #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gas1cent
reviewed
Mar 5, 2024
Comment on lines
+216
to
+219
| // Cant have more then one notice tag | ||
| if (noticeCounter > 1) { | ||
| alerts.push(`@notice is duplicated`); | ||
| } |
There was a problem hiding this comment.
I believe it's a valid scenario. At the same time, having duplicated @param tags should be prohibited.
gas1cent
reviewed
Mar 5, 2024
Comment on lines
+59
to
+62
| Object.keys(this.config.functions[key as keyof Functions].tags).forEach((tag) => { | ||
| if (this.config.functions[key as keyof Functions][tag as keyof FunctionConfig]) { | ||
| needsWarning = true; | ||
| } |
There was a problem hiding this comment.
One thing to note here, we could avoid repeating as keyof by converting the config into a class and adding helpers to it. This approach will also help with retrieving the rest of the rules, let's discuss it later when the logic is fully developed.
excaliborr
changed the title
gas1cent
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Linear
Closes BES-251