Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: no fuzz integration #60

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

test: no fuzz integration #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
807cd6e
test: remove fuzz in integration tests
xorsal Nov 21, 2024
bcd3a69
Merge branch 'dev' into test/no-fuzz-integration
xorsal Dec 9, 2024
64758ea
chore: remove commented line
xorsal Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions solidity/test/integration/Finalization.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,8 @@ contract Integration_Finalization is IntegrationBase {
/**
* @notice Test to check that finalization data is set and callback calls are made.
*/
function test_makeAndIgnoreLowLevelCalls(bytes memory _calldata) public {
function test_makeAndIgnoreLowLevelCalls() public {
bytes memory _calldata = bytes('calldata');
mockRequest.finalityModuleData =
abi.encode(IMockFinalityModule.RequestParameters({target: _callbackTarget, data: _calldata}));

Expand Down Expand Up @@ -115,7 +116,8 @@ contract Integration_Finalization is IntegrationBase {
/**
* @notice Test to check that finalizing a request without disputes triggers callback calls and executes without reverting.
*/
function test_finalizeWithUndisputedResponse(bytes calldata _calldata) public {
function test_finalizeWithUndisputedResponse() public {
bytes memory _calldata = bytes('some-calldata');
mockRequest.finalityModuleData =
abi.encode(IMockFinalityModule.RequestParameters({target: _callbackTarget, data: _calldata}));

Expand Down
7 changes: 4 additions & 3 deletions solidity/test/integration/ResponseProposal.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,8 @@ contract Integration_ResponseProposal is IntegrationBase {
_requestId = oracle.createRequest(mockRequest, _ipfsHash, mockAccessControl);
}

function test_proposeResponse_validResponse(bytes memory _response) public {
function test_proposeResponse_validResponse() public {
bytes memory _response = bytes('valid-response');
mockResponse.response = _response;

// Revert if not approved to create request
Expand Down Expand Up @@ -79,8 +80,8 @@ contract Integration_ResponseProposal is IntegrationBase {
assertEq(_responseIds[0], _getId(mockResponse));
}

function test_proposeResponse_finalizedRequest(uint256 _timestamp) public {
_timestamp = bound(_timestamp, _expectedDeadline + _baseDisputeWindow, type(uint128).max);
function test_proposeResponse_finalizedRequest() public {
uint256 _timestamp = _expectedDeadline + _baseDisputeWindow;

// Propose response
mockAccessControl.user = proposer;
Expand Down
Loading