Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: m-01 unfinalizable requests #62

Open
wants to merge 1 commit into
base: fix/oz-audit
Choose a base branch
from
+3 −0
Open

fix: m-01 unfinalizable requests #62

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions solidity/interfaces/IModule.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,9 @@ interface IModule is IValidator {
/**
* @notice Finalizes the request
*
* @dev Requests could become unfinilizable if the Request object is malformed or custom modules are not properly implemented.
* Participants should call the validateParameters function for every module in the request to ensure correctness before
* interacting with requests.
* @param _request The request being finalized
* @param _response The final response
* @param _finalizer The address that initiated the finalization
Expand Down
Loading