-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: updated action args #50
Conversation
* refactor: removed create packages and move the logic to create package * refactor: changed typing type to export type and changed abi for interface * feat: created copy solidity files function * refactor: removed sample interface on create readme function
BES-87 Refactor the action
Defaults:
Can we figure Refactor:
|
Notes:
|
// Copy the interfaces and their ABIs | ||
copySolidityFiles(outDir, interfacesDir, destinationDir); | ||
|
||
// Copy the contracts only if the export type is contracts | ||
if (exportType === ExportType.CONTRACTS) copySolidityFiles(outDir, contractsDir, destinationDir); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idea: Instead of exporting the interfaces ABIs as default, could we have an if for each exportType
?
If the user wants to only export the interfaces he can set interfaces
as argument. If he wants to export only the contracts he can set contracts
. If he wants both, he could set all
.
By this way, we wouldn't be forcing to export the interfaces if the user only wants to export contracts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻 added this to Linear to think about later.
* refactor: exported copy solidity file as non default function * fix: fixed typos over comments
refactor: removed create packages and move the logic to create package
refactor: changed typing type to export type and changed abi for interface
feat: created copy solidity files function
refactor: removed sample interface on create readme function
CLOSES BES-87