Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change license of contracts #34

Merged
merged 1 commit into from
Nov 23, 2023
Merged

fix: change license of contracts #34

merged 1 commit into from
Nov 23, 2023

Conversation

dristpunk
Copy link
Contributor

@dristpunk dristpunk commented Nov 15, 2023

Closes BES-95

@dristpunk dristpunk self-assigned this Nov 15, 2023
Copy link

linear bot commented Nov 21, 2023

BES-95 Change license to MIT

  1. In Greeter.sol, change
// SPDX-License-Identifier: UNLICENSED

To

// SPDX-License-Identifier: MIT
  1. Add LICENSE file, like this one: https://github.com/defi-wonderland/foundry-mock-generator/blob/c9d4cfc967fce7f64034d339a5d8d555096f3607/LICENSE
  2. Mention the license in package.json: "license": "MIT"
  3. Mention the license in the README

Licensing
The primary license for the mock generator is MIT, see LICENSE.

@dristpunk dristpunk marked this pull request as ready for review November 22, 2023 07:30
@@ -111,13 +111,13 @@
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it OK for the out directory to exist in git?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mm I agree this should be generated when building and should be removed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.gitignore says that

# Keep related abi
out/*/*
!out/Greeter.sol/*

don't we really need it in boilerplate?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that Greeter output is not worth keeping.

Copy link
Member

@0xRaccoon 0xRaccoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The out folder should be removed. Other than that, it looks good to me

@gas1cent gas1cent merged commit e88aeac into main Nov 23, 2023
6 checks passed
@gas1cent gas1cent deleted the fix/change-license branch November 23, 2023 06:19
xorsal pushed a commit that referenced this pull request Sep 27, 2024
xorsal pushed a commit that referenced this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants