This repository has been archived by the owner on Aug 13, 2024. It is now read-only.
Add confirmation support. #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricklamers
requested review from
colemccracken,
jordan-wu-97 and
dloman118
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Your Render PR Server URL is https://openassistants-fast-api-server-pr-54.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cm0bfuta73kc73cqe0p0. |
scripts/run.sh
Outdated
|
|
||
| ( | ||
| cd examples/fast-api-server | ||
| poetry run ./run.sh |
There was a problem hiding this comment.
Took a comment to slack about this
There was a problem hiding this comment.
What about in the Makefile instead?
There was a problem hiding this comment.
I dont have strong opinions either way. Happy to ship and revisit later if it becomes a problem
colemccracken
approved these changes
Dec 18, 2023
jordan-wu-97
approved these changes
Dec 18, 2023
Makefile
Outdated
Comment on lines
22
to
23
| @(cd examples/fast-api-server && poetry run ./run.sh) & | ||
| @(cd examples/next && yarn dev) & |
There was a problem hiding this comment.
break out as separate tasks?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added basic utility scripts for running both servers during development with a single command.