Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #2

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Fixes #2

merged 1 commit into from
Jun 7, 2024

Conversation

wongjingping
Copy link
Contributor

@wongjingping wongjingping commented Jun 7, 2024 •
edited
Loading

Added more keywords that we should exclude when generating table aliases.
Exclude tests directory from package installation.

The reason for adding go is because of this weird sqlparse.format error as well:

sql = "SELECT game_id FROM game_outcomes go WHERE go.duration > 120;"
sqlparse.format(sql, keyword_case="upper", strip_whitespace=True, strip_comments=True)
# 'SELECT game_id FROM game_outcomes GOWHERE go.duration > 120;'

@wongjingping
Added more keywords to exclude table aliases from.
a127520 
Exclude tests directory from package installation.
rishsriv
rishsriv approved these changes Jun 7, 2024
View reviewed changes
defog_utils/utils_db.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@wongjingping wongjingping merged commit 262f74a into main Jun 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rishsriv rishsriv rishsriv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wongjingping @rishsriv