Add strftime to SQL features #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wendy-aw
commented
Jun 7, 2024
wendy-aw
commented
- added strftime feature for sqlite
- modified current_date_time_expressions to include CurrentDatetime
- added dialect to sqlglot parsing
- realized "now" is not always an anonymous expression, so added a line for that
- modified current_date_time_expressions - added dialect to sqlglot parsing
rishsriv
reviewed
Jun 7, 2024
| @@ -293,7 +296,7 @@ def get_sql_features( | |||
| if " ~ '" in sql: | |||
| sql = sql.replace(" ~ '", " LIKE '") | |||
| sql = re.sub("character varying", "varchar", sql, flags=re.IGNORECASE) | |||
| parsed = parse_one(sql) | |||
| parsed = parse_one(sql, dialect) | |||
rishsriv
reviewed
Jun 7, 2024
| @@ -385,6 +388,8 @@ def get_sql_features( | |||
| features.rank = True | |||
| elif isinstance(node, exp.DateTrunc): | |||
| features.date_trunc = True | |||
| elif isinstance(node, exp.TimeToStr): | |||
wongjingping
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.