-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix translation script #179
Conversation
- add pretty arg to preserve new lines in ddl - add semicolon after all CREATE TABLE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes Wendy! Just checking if this also fixes the "schema present in cot_instructions
" problem?
Ahh yesss my bad I forgot about that. That's still there. Working on it now! |
Awesome, thank you! Feel free to just tag me here once you make a push and we can then merge it :D |
I also made a tiny change to the cot prompt! |
Thanks Wendy! Looks good to me. Merging! |
ddl_to_dialect
which had redundant preprocessing that was accidentally removing some column descriptions.pretty=True