Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translated latest questions_gen #186

Merged
merged 5 commits into from
Jun 26, 2024
Merged

Translated latest questions_gen #186

merged 5 commits into from
Jun 26, 2024

Conversation

wendy-aw
Copy link
Contributor

  • Translated newest questions_gen based on Added 10 more date questions #180 with translate_sql_dialect.py
    Minor edits:
  • Changed splitting of sqlite DDL due to new pretty=True which preserves new lines
  • Remove public. schema names in questions_gen_postgres
  • Fill nans with empty strings in translate script
  • Added missing pyodbc import in test_valid_md_tsql

rishsriv
rishsriv approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@rishsriv rishsriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the translations!

@rishsriv
Copy link
Member

rishsriv commented Jun 26, 2024 •
edited
Loading

Feel free to lint and then 🚢

@wendy-aw wendy-aw merged commit b7d1c1a into main Jun 26, 2024
2 checks passed
@wendy-aw wendy-aw deleted the wendy/trans_qn_gen branch June 26, 2024 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rishsriv rishsriv rishsriv approved these changes

@wongjingping wongjingping Awaiting requested review from wongjingping

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wendy-aw @rishsriv