Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manual entry for migrating shader versions #461

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

Jhonnyg
Copy link
Contributor

@Jhonnyg Jhonnyg commented Aug 12, 2024

No description provided.


### Precision

Setting explicit precision for variables, inputs, outputs and so forth was previously required in order to be compliant with OpenGL ES contexts. This is not required anymore, precision is now set automatically for platforms that support it.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but it's still possible to specify it, right? if I want to optimize something?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be, but I'm not actually seeing it in the output.. I'll have to investigate a bit, we might be running into this:
KhronosGroup/SPIRV-Cross#401

@Jhonnyg Jhonnyg merged commit 9b6ba0b into master Aug 13, 2024
1 check passed
@Jhonnyg Jhonnyg deleted the shader-migration-manual-entry branch August 13, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants