Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defining project_path stuck in recursion #72

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Defining project_path stuck in recursion #72

wants to merge 1 commit into from

Conversation

mptre
Copy link

@mptre mptre commented Oct 1, 2011

I experienced some difficulties while trying to start the cijoe server on my local machine (OS X). The set call on line 103 got stuck in recursion. This could be solved by passing the third parameter named ignore_setter.

@awd
Copy link

awd commented Oct 6, 2011

Please merge this into master. I also had the same problem, this commit resolved it.

@eyberg
Copy link

eyberg commented Oct 17, 2011

I had this same problem as well

@marceldegraaf
Copy link

+1, same problem here

@marceldegraaf
Copy link

FYI: this patch no longer seems to work with Sinatra 1.1.3. Just tried it and got this:

/Users/mdg/.rvm/gems/ruby-1.9.2-p136/gems/sinatra-1.1.3/lib/sinatra/base.rb:865:in `set': wrong number of arguments (3 for 2) (ArgumentError)
    from /Users/mdg/.rvm/gems/ruby-1.9.2-p136/gems/cijoe-0.9.4/lib/cijoe/server.rb:107:in `project_path='
    from /Users/mdg/.rvm/gems/ruby-1.9.2-p136/gems/sinatra-1.1.3/lib/sinatra/base.rb:875:in `set'
    from /Users/mdg/.rvm/gems/ruby-1.9.2-p136/gems/cijoe-0.9.4/lib/cijoe/server.rb:90:in `start'
    from /Users/mdg/.rvm/gems/ruby-1.9.2-p136/gems/cijoe-0.9.4/bin/cijoe:50:in `<top (required)>'
    from /Users/mdg/.rvm/gems/ruby-1.9.2-p136/bin/cijoe:19:in `load'
    from /Users/mdg/.rvm/gems/ruby-1.9.2-p136/bin/cijoe:19:in `<main>'

@yaotti
Copy link

yaotti commented Nov 1, 2011

+1. This commit resolved the issue for me with sinatra 1.3.1.

@tiagogodinho
Copy link

👍

@mptre
Copy link
Author

mptre commented Nov 2, 2011

I'm still experiencing the same problem using Sinatra 1.3.1. This commit is yet working as a solution.

@linuxsable
Copy link

+1, same issue

@potomak
Copy link

potomak commented Dec 9, 2011

+1

2 similar comments
@ncreuschling
Copy link

+1

@maljub01
Copy link

maljub01 commented Feb 7, 2012

+1

@kenmazaika
Copy link

+1

CIJoe was unusable without making this change manually. Once I did it worked. Would be nice to see this in master.

@relrod
Copy link

relrod commented Apr 4, 2012

+1...

@stas
Copy link

stas commented Apr 4, 2012

+1

@defrex
Copy link

defrex commented Apr 23, 2012

+1

Is this project still maintained? 7 months of people having to manually patch a fundamental fix seems to long.

@potomak
Copy link

potomak commented Apr 23, 2012

Maybe not, if you look carefully at project's URL you'll see it says:
defunkt/cijoe
On Apr 23, 2012 8:23 PM, "defrex" <
[email protected]>
wrote:

+1

Is this project still maintained? 7 months of people having to manually
patch a fundamental fix seems to long.


Reply to this email directly or view it on GitHub:
#72 (comment)

@defrex
Copy link

defrex commented Apr 23, 2012

You're saying the founder of GitHub has something better to do then patch a CI server that they don't use anymore? To bad, Jenkins is bloated and ugly.

@DNNX
Copy link

DNNX commented Aug 28, 2012

+1

1 similar comment
@prakhar1989
Copy link

+1

@suriyaa suriyaa mentioned this pull request Apr 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.