Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: updated dashboard schema to support the new one #25

Merged
merged 2 commits into from
May 11, 2022
Merged

Chore: updated dashboard schema to support the new one #25

merged 2 commits into from
May 11, 2022

Conversation

pciang
Copy link
Contributor

@pciang pciang commented May 6, 2022 •
edited
Loading

Description

I will also create a new tag for this PR. This PR unblocks https://github.com/deliveryhero/logistics-dashboards/pull/294

Changes:

  • Updated dashboard schema, the old row schema is now deprecated but is still supported.
  • This PR temporarily supports both schemas to allow a transition period.
  • Panels in the new schema must have gridPos
  • Updated unit tests

@pciang pciang force-pushed the update-dashboard-schema branch 4 times, most recently from eb6a8f4 to 6cb593a Compare May 9, 2022 09:48
@pciang pciang changed the title Chore: update dashboard schema, deprecated variables are now optional Chore: update dashboard schema, deprecating the old row May 9, 2022
@pciang pciang changed the title Chore: update dashboard schema, deprecating the old row Chore: update dashboard schema, deprecating the old row schema May 9, 2022
@pciang pciang force-pushed the update-dashboard-schema branch 3 times, most recently from 84bc6fe to cd5aa32 Compare May 10, 2022 11:59
@pciang pciang changed the title Chore: update dashboard schema, deprecating the old row schema Chore: updated dashboard schema to support the new one May 10, 2022
@pciang pciang force-pushed the update-dashboard-schema branch 2 times, most recently from df82cc4 to 81ebdb9 Compare May 10, 2022 12:24
@pciang pciang force-pushed the update-dashboard-schema branch from 81ebdb9 to 8955417 Compare May 10, 2022 12:29
goelankitt
goelankitt suggested changes May 11, 2022
View reviewed changes
Copy link
Contributor

@goelankitt goelankitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update the Github README with the update about the deprecation of the old graph panel?

@pciang
Copy link
Contributor Author

pciang commented May 11, 2022

Can you also update the Github README with the update about the deprecation of the old graph panel?

Updated the simplest dashboard in README: 0759f42

Will also update the advanced example as soon as the transform script is ready and executed.

@pciang pciang merged commit accf8dc into master May 11, 2022
@pciang pciang deleted the update-dashboard-schema branch May 11, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goelankitt goelankitt goelankitt approved these changes

@nyambati nyambati nyambati approved these changes

@javad-hajiani javad-hajiani Awaiting requested review from javad-hajiani

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pciang @goelankitt @nyambati