Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Check for Hard Limit in ControllerExpandVolume #335

Merged
merged 3 commits into from
Feb 25, 2025

Conversation

KshitijaKakde
Copy link
Contributor

@KshitijaKakde KshitijaKakde commented Jan 30, 2025

Description

Add Check for Hard Limit Not Set to 0 in ControllerExpandVolume

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1726

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

  1. Reproduced the issue by installing the driver, creating a filesystem, removing the hard limit from the array, and attempting to expand the volume. The error message observed was: panic: runtime error: integer divide by zero.
  2. Built a new image with the fix and installed the driver with this new image.
  3. Attempted to expand the filesystem by removing the hard limit from the array. The following error message was observed: "Hard limit is 0, cannot proceed with volume expansion."

@suryagupta4 suryagupta4 merged commit 458d82d into main Feb 25, 2025
6 checks passed
@suryagupta4 suryagupta4 deleted the usr/kshitija/fix-hardlimit branch February 25, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants