Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated PowerMax Documentation #1450

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Updated PowerMax Documentation #1450

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68522b9
Updated PowerMax Documentation
rishabhatdell Feb 11, 2025
993bf6a
Update powermax.md
rishabhatdell Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions content/docs/csidriver/features/powermax.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -670,6 +670,8 @@ This feature is also supported for limiting the volume provisioning on Kubernete

The CSI Driver for Dell PowerMax supports NVMeTCP from v2.11.0. To enable NVMe/TCP provisioning, blockProtocol in settings file should be specified as NVMETCP.

>**NOTE:** <br>If `X_CSI_TRANSPORT_PROTOCOL` is not specified in the powermax-array-config ConfigMap, the driver will detect the available initiators on the host and choose the protocol. Priority is given to NVMe/TCP, followed by FC, then iSCSI.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we specify both i.e. AUTO and the empty value as both cases are handled in our driver code base?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so, because here
https://github.com/dell/csi-powermax/blob/1c59cc178a2af03fe436bdd9c1ec60159de7be5f/service/service.go#L730
it just accept these values

FIBRE : Returns FC
FC : Returns FC
ISCSI : Returns ISCSI
NVMETCP : Returns NVMETCP
Empty string ("") : Returns an empty string
Invalid value (e.g., AUTO) : Logs an error and returns an empty string

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Auto is a valid input or not, please refer this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the documentation, if no value is specified, it defaults to "Auto." This means "Auto" is a valid input and should be supported. Supporting "Auto" will ensure consistency with other drivers, such as PowerStore, which also recognize "Auto" as a valid input.

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added it to csi-powermax and documentation


**Limitations**

These are the CSM modules not supported with NVMeTCP protocol:
Expand Down
Loading