Skip to content

Commit

Permalink
CR
Browse files Browse the repository at this point in the history
  • Loading branch information
jaidhyani committed Apr 5, 2024
1 parent 0cc0c98 commit 2b85f78
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 46 deletions.
5 changes: 4 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -174,4 +174,7 @@ cython_debug/
notebooks/scratch.ipynb

# dsstore
.DS_Store
.DS_Store

# vscode debug configs
**/launch.json
42 changes: 0 additions & 42 deletions .vscode/launch.json

This file was deleted.

2 changes: 1 addition & 1 deletion scripts/run_training.py
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ def setup_parser() -> argparse.ArgumentParser:


def overrides_to_dict(overrides: list[str]) -> dict[str, Any]:
# {"--overrides a.b.c=4 foo=false} to {"a": {"b": {"c": 4}}, "foo": False}
# ["a.b.c=4", "foo=false"] to {"a": {"b": {"c": 4}}, "foo": False}
config_vars = {k: v for k, v in [x.split("=") for x in overrides if "=" in x]}
return dot_notation_to_dict(config_vars)

Expand Down
3 changes: 1 addition & 2 deletions src/delphi/train/config/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,13 @@
import json
import logging
import os
from collections.abc import Iterable
from dataclasses import fields, is_dataclass
from datetime import datetime
from pathlib import Path
from typing import _GenericAlias # type: ignore
from typing import Any, Type, TypeVar, Union

import platformdirs
from beartype.typing import Any, Iterable
from dacite import from_dict

from delphi.constants import CONFIG_PRESETS_DIR
Expand Down

0 comments on commit 2b85f78

Please sign in to comment.