Skip to content

Commit

Permalink
don't ignore incorrect config keys
Browse files Browse the repository at this point in the history
  • Loading branch information
jaidhyani committed Apr 20, 2024
1 parent d9f434c commit 8e6245b
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/delphi/train/config/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
from typing import Any, Type, TypeVar, Union

import platformdirs
from dacite import Config as dacite_config
from dacite import from_dict

from .training_config import TrainingConfig
Expand Down Expand Up @@ -124,7 +125,7 @@ def build_config_from_files_and_overrides(
cast_types(overrides, TrainingConfig)
merge_two_dicts(merge_into=combined_config, merge_from=overrides)
set_backup_vals(combined_config, config_files)
return from_dict(TrainingConfig, combined_config)
return from_dict(TrainingConfig, combined_config, config=dacite_config(strict=True))


def dot_notation_to_dict(vars: dict[str, Any]) -> dict[str, Any]:
Expand Down

0 comments on commit 8e6245b

Please sign in to comment.