Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HF revamp #128

Merged
merged 1 commit into from
Apr 27, 2024
Merged

HF revamp #128

merged 1 commit into from
Apr 27, 2024

Conversation

jettjaniak
Copy link
Contributor

  • we never pass tokens as argument, it needs to be set in env variable HF_TOKEN
  • training config needs out_repo_id - set to empty string if you don't want to upload to hf
    • if this is provided, every checkpoint and final model will be uploaded to HF
  • training config has save_optimizer: bool = True
  • changed folder structure for saved models to be easily loadable from HF

@jettjaniak jettjaniak requested review from jaidhyani and SrGonao April 25, 2024 18:07
Copy link
Contributor

@SrGonao SrGonao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

Copy link
Collaborator

@jaidhyani jaidhyani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jaidhyani jaidhyani merged commit 9feac6e into main Apr 27, 2024
1 check passed
@jettjaniak jettjaniak deleted the hf-revamp branch May 22, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants