Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle CUBLAS_WORKSPACE_CONFIG env var #139

Merged
merged 2 commits into from
May 20, 2024
Merged

Conversation

jettjaniak
Copy link
Contributor

No description provided.

@jettjaniak jettjaniak requested review from jaidhyani and SrGonao May 15, 2024 11:46
@jettjaniak jettjaniak linked an issue May 15, 2024 that may be closed by this pull request
Copy link
Contributor

@SrGonao SrGonao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My problem with this is that there will be a warning and then there will be a crash - torch just refuses to proceed if the correct value is not set- and so people will just see too warnings. I don't know if the best thing would just be to set it to the expected value?

@jettjaniak jettjaniak force-pushed the CUBLAS_WORKSPACE_CONFIG branch from d29d377 to 35771c3 Compare May 20, 2024 10:36
@jettjaniak
Copy link
Contributor Author

you're right, fixed!

@jettjaniak jettjaniak force-pushed the CUBLAS_WORKSPACE_CONFIG branch from 35771c3 to 0cd5e29 Compare May 20, 2024 10:40
@jettjaniak jettjaniak merged commit 632a08c into main May 20, 2024
1 check passed
@jettjaniak jettjaniak deleted the CUBLAS_WORKSPACE_CONFIG branch May 20, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CUBLAS_WORKSPACE_CONFIG
2 participants