build for oem partners #462
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebroy
reviewed
Aug 25, 2023
I created an |
| - --enable challenge-response | ||
| - --remove unix | ||
| when: | ||
| - variant is regex("external-.*") |
There was a problem hiding this comment.
maybe change this to:
when:
- variant != "external-minimal"
- variant is regex("external-.*")
as-is, this will disable CRA for the product, right?
There was a problem hiding this comment.
I do not intend to merge this PR. It was designed to create a one-time build and I posted the PR to make sure that we're not exposing anything of concern to anybody that uses this build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a draft for an external build we intend to share with our partners. This PR is part of the external-minimal variant (see delphix/appliance-build#735)