Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
= Changes
setup.py: add standard fields and fix any references to sdimitro repo
setup.py: add dependencies in setup.py and point requirements.txt to it
github actions: add testing for creating distribution archives
= Motivation
With this patch applied we are getting one step closer to publish SDB on PyPI
at which point anyone would be able to install it using
pip
. The remainingwork would be to register an account on PyPI and have a job that pushed
nightlies and official version of SDB on the registry.
= Tests
python3 -m pip install -r requirements.txt
installsdrgn
as expectedpython3 setup.py sdist bdist_wheel
creates adist
directory with no errorsPublished this as a package in TestPyPI -> https://test.pypi.org/project/sdb/0.1.0/
The above link is not official but a dry-run before we actually create an entry on PyPI.
= References Used For This Patch
[1] https://packaging.python.org/tutorials/packaging-projects/
[2] https://packaging.python.org/discussions/install-requires-vs-requirements/ and https://stackoverflow.com/questions/14399534/reference-requirements-txt-for-the-install-requires-kwarg-in-setuptools-setup-py