Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize SDB packaging #201

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sdimitro
Copy link
Contributor

= Changes

setup.py: add standard fields and fix any references to sdimitro repo
setup.py: add dependencies in setup.py and point requirements.txt to it
github actions: add testing for creating distribution archives

= Motivation

With this patch applied we are getting one step closer to publish SDB on PyPI
at which point anyone would be able to install it using pip. The remaining
work would be to register an account on PyPI and have a job that pushed
nightlies and official version of SDB on the registry.

= Tests

  • python3 -m pip install -r requirements.txt installs drgn as expected
  • python3 setup.py sdist bdist_wheel creates a dist directory with no errors

Published this as a package in TestPyPI -> https://test.pypi.org/project/sdb/0.1.0/
The above link is not official but a dry-run before we actually create an entry on PyPI.

= References Used For This Patch

[1] https://packaging.python.org/tutorials/packaging-projects/
[2] https://packaging.python.org/discussions/install-requires-vs-requirements/ and https://stackoverflow.com/questions/14399534/reference-requirements-txt-for-the-install-requires-kwarg-in-setuptools-setup-py

setup.py: add dependencies in setup.py and point requirements.txt to it
github actions: add testing for creating distribution archives
@codecov-io
Copy link

codecov-io commented Mar 18, 2020

Codecov Report

Merging #201 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #201   +/-   ##
=======================================
  Coverage   85.46%   85.46%           
=======================================
  Files          58       58           
  Lines        2346     2346           
=======================================
  Hits         2005     2005           
  Misses        341      341

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d496a03...2406c34. Read the comment docs.

@dlpx-tfc-github-manager dlpx-tfc-github-manager bot deleted the branch delphix:master January 5, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants