chore: remove lazy_static and once_cell dependencies #3148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyurik
requested review from
wjones127,
fvaleye,
roeap,
ion-elgreco,
rtyler and
hntd187
as code owners
github-actions
bot
added
binding/python
nyurik
force-pushed
the
remove-lazy-static
branch
from
b1accc7 to
9e86284
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3148 +/- ##
==========================================
+ Coverage 71.96% 72.15% +0.19%
==========================================
Files 135 137 +2
Lines 43581 44082 +501
Branches 43581 44082 +501
==========================================
+ Hits 31361 31808 +447
- Misses 10181 10243 +62
+ Partials 2039 2031 -8 ☔ View full report in Codecov by Sentry. |
nyurik
force-pushed
the
remove-lazy-static
branch
from
9e86284 to
561c52e
Compare
nyurik
changed the title
roeap
previously approved these changes
Jan 21, 2025
|
@nyurik - looks like we need one more |
LazyLock has been available since 1.80 which is less than MSRV Signed-off-by: Yuri Astrakhan <[email protected]>
rtyler
force-pushed
the
remove-lazy-static
branch
from
561c52e to
433eb97
Compare
rtyler
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
LazyLock has been available since 1.80 which is less than MSRV