Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: separate runtime for python IO #3283

Closed

Conversation

ion-elgreco
Copy link
Collaborator

Description

Probably solves the panic with long running tasks

Related Issue(s)

@ion-elgreco ion-elgreco force-pushed the fix/seperate_io_rt_python branch from f013cbc to 06a7f2b Compare March 1, 2025 12:40
@github-actions github-actions bot added the binding/python Issues for the Python package label Mar 1, 2025
@ion-elgreco ion-elgreco force-pushed the fix/seperate_io_rt_python branch from 06a7f2b to 7ef2007 Compare March 1, 2025 13:19
@ion-elgreco ion-elgreco enabled auto-merge March 1, 2025 13:20
Copy link

codecov bot commented Mar 1, 2025

Codecov Report

Attention: Patch coverage is 0% with 33 lines in your changes missing coverage. Please review.

Project coverage is 72.12%. Comparing base (19fb4a1) to head (d5b86b1).

Files with missing lines Patch % Lines
python/src/filesystem.rs 0.00% 20 Missing ⚠️
python/src/utils.rs 0.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3283      +/-   ##
==========================================
- Coverage   72.14%   72.12%   -0.03%     
==========================================
  Files         143      143              
  Lines       45668    45688      +20     
  Branches    45668    45688      +20     
==========================================
+ Hits        32949    32951       +2     
- Misses      10634    10653      +19     
+ Partials     2085     2084       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ion-elgreco ion-elgreco disabled auto-merge March 8, 2025 20:31
@ion-elgreco
Copy link
Collaborator Author

@rtyler i actually need to use the with_io_runtime constructs here, I have this in some commits laying around, will address that once Im back

@ion-elgreco ion-elgreco closed this Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/python Issues for the Python package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Runtime panic in new streaming writer: Cannot start a runtime from within a runtime
2 participants