Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle missing artifacts gracefully #24

Merged
merged 5 commits into from
Dec 27, 2023
Merged

Handle missing artifacts gracefully #24

merged 5 commits into from
Dec 27, 2023

Conversation

dorschw
Copy link
Contributor

@dorschw dorschw commented Dec 26, 2023 •
edited
Loading

bumped upload-artifact to v4, and now:

  1. If a lint output file is missing (happens when lint has no files to run on), it's ignored instead of failing. (see provided argument)
  2. If other artifacts (id-set, content artifacts) are not available during their upload stage, fail (preserving previous behavior)
    fixes: CIAC-7718

@dorschw dorschw marked this pull request as ready for review December 26, 2023 15:54
@dorschw dorschw merged commit ba37a1a into master Dec 27, 2023
1 check passed
@dorschw dorschw deleted the ds-handle-missing-artifcats branch December 27, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuvalbenshalom yuvalbenshalom yuvalbenshalom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dorschw @yuvalbenshalom