Zip file fix #34399
Merged
Zip file fix #34399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talzich
requested review from
GuyAfik,
JudahSchwartz and
samuelFain
as code owners
Coverage Report
|
||||||||||||||||||||||||||||||
5 tasks
JudahSchwartz
approved these changes
May 22, 2024
maimorag
pushed a commit
that referenced
this pull request
May 27, 2024
* Ignore ZipFile in native image * Add UT to ZipFile * Update Packs/CommonScripts/Scripts/ZipFile/ZipFile.py Co-authored-by: Judah Schwartz <[email protected]> * Address CR for ZipFile Script * Remove test-files from ZipFile * Fix bug in ZipFile * Add RN and update version for CommonScripts * Fix RN and and pre-commit changes * address validation errors * Address CR on ZipFile test * Add troubleshooting section to README * Fix pre-commit errors * Empty commit * Update docker image * Update docker image and fix validations error * Update RN and pack version for CommonScripts --------- Co-authored-by: Judah Schwartz <[email protected]>
maimorag
pushed a commit
that referenced
this pull request
May 29, 2024
* Ignore ZipFile in native image * Add UT to ZipFile * Update Packs/CommonScripts/Scripts/ZipFile/ZipFile.py Co-authored-by: Judah Schwartz <[email protected]> * Address CR for ZipFile Script * Remove test-files from ZipFile * Fix bug in ZipFile * Add RN and update version for CommonScripts * Fix RN and and pre-commit changes * address validation errors * Address CR on ZipFile test * Add troubleshooting section to README * Fix pre-commit errors * Empty commit * Update docker image * Update docker image and fix validations error * Update RN and pack version for CommonScripts --------- Co-authored-by: Judah Schwartz <[email protected]>
aaron1535
pushed a commit
that referenced
this pull request
Jun 9, 2024
* Ignore ZipFile in native image * Add UT to ZipFile * Update Packs/CommonScripts/Scripts/ZipFile/ZipFile.py Co-authored-by: Judah Schwartz <[email protected]> * Address CR for ZipFile Script * Remove test-files from ZipFile * Fix bug in ZipFile * Add RN and update version for CommonScripts * Fix RN and and pre-commit changes * address validation errors * Address CR on ZipFile test * Add troubleshooting section to README * Fix pre-commit errors * Empty commit * Update docker image * Update docker image and fix validations error * Update RN and pack version for CommonScripts --------- Co-authored-by: Judah Schwartz <[email protected]>
pal-xmco
pushed a commit
to pal-xmco/content
that referenced
this pull request
Jun 19, 2024
* Ignore ZipFile in native image * Add UT to ZipFile * Update Packs/CommonScripts/Scripts/ZipFile/ZipFile.py Co-authored-by: Judah Schwartz <[email protected]> * Address CR for ZipFile Script * Remove test-files from ZipFile * Fix bug in ZipFile * Add RN and update version for CommonScripts * Fix RN and and pre-commit changes * address validation errors * Address CR on ZipFile test * Add troubleshooting section to README * Fix pre-commit errors * Empty commit * Update docker image * Update docker image and fix validations error * Update RN and pack version for CommonScripts --------- Co-authored-by: Judah Schwartz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Related Issues
fixes: link to the issue
Description
Replacing
pyminizipwithpyzipperbecause of this issueMust have