Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for IoC Incident Feed #37021

Conversation

klevitskiy-cyberint
Copy link
Contributor

@klevitskiy-cyberint klevitskiy-cyberint commented Nov 1, 2024

  • Fixed mirroring feature
  • Added internal identifier of alert to incident fields

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

A few sentences describing the overall goals of the pull request's commits.

Must have

  • Tests
  • Documentation

Screen-Recording-2024-10-31-at-10 25 10

Screen Recording 2024-11-22 at 12 12 05 (1)

klevitskiy-cyberint and others added 2 commits November 1, 2024 23:20
- Added support for IoC Incident Feed
- Added internal identifier of alert to incident fields
@content-bot content-bot added Contribution Thank you! Contributions are always welcome! External PR Partner Support Level Indicates that the contribution is for Partner supported pack labels Nov 1, 2024
@content-bot content-bot changed the base branch from master to contrib/CyberInt_feature/sync-indicators November 1, 2024 22:32
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @yaakovpraisler will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

@content-bot
Copy link
Collaborator

Hi @klevitskiy-cyberint, thanks for contributing to the XSOAR marketplace. To receive credit for your generous contribution please follow this link.

@edik24 edik24 self-assigned this Nov 4, 2024
@content-bot content-bot added Partner-Approved Contribution Form Filled Whether contribution form filled or not. Partner labels Nov 4, 2024
@yaakovpraisler yaakovpraisler requested review from samuelFain and removed request for yaakovpraisler November 17, 2024 08:04
@samuelFain
Copy link
Contributor

Hi @klevitskiy-cyberint, we apologize for the delay in reviewing this PR.
A developer from our team will review it as soon as possible. We appreciate your patience.

@klevitskiy-cyberint
Copy link
Contributor Author

Hi @samuelFain, thank you for the update and for keeping us informed. We really appreciate your team's effort and understand that reviews can take time.
That said, our mutual client has inquired about the progress of this PR, and I was wondering if it would be possible to share an estimated timeline for the review? This will help us better align expectations on our side.
Thanks again for your support, and please let me know if there’s anything I can do to assist in expediting the process.

@samuelFain samuelFain assigned MLainer1 and unassigned samuelFain Nov 18, 2024
@klevitskiy-cyberint
Copy link
Contributor Author

Hi @MLainer1

There’s one remaining issue:

[RN103] - Please complete the release notes and ensure all placeholders are filled in.For common troubleshooting steps, please review the documentation found here: https://xsoar.pan.dev/docs/integrations/changelog#common-troubleshooting-tips

I followed the recommendations in the guide, but the issue remains unresolved. Could you assist in addressing this?

Thank you!

@MLainer1
Copy link
Contributor

Hi @klevitskiy-cyberint, I think the issue is that the pack version should be changed to 1.1.5, as version 1.1.4 already exists.
Make sure to change also the .json file and the .md file accordingly (for version 1.1.5)

@klevitskiy-cyberint
Copy link
Contributor Author

Hi @klevitskiy-cyberint, I think the issue is that the pack version should be changed to 1.1.5, as version 1.1.4 already exists. Make sure to change also the .json file and the .md file accordingly (for version 1.1.5)

Thanks! I’ve updated the version—fingers crossed it’s resolved now.

@klevitskiy-cyberint you can also run the command demisto-sdk pre-commit on your local development enviroment

The output differs when run locally.

@MLainer1 MLainer1 added the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Jan 23, 2025
@content-bot
Copy link
Collaborator

For the Reviewer: Trigger build request has been accepted for this contribution PR.

@content-bot
Copy link
Collaborator

For the Reviewer: Successfully created a pipeline in GitLab with url: https://gitlab.xdr.pan.local/xdr/cortex-content/content/-/pipelines/2060265

@content-bot content-bot removed the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Jan 23, 2025
@MLainer1 MLainer1 added the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Jan 26, 2025
@content-bot
Copy link
Collaborator

For the Reviewer: Trigger build request has been accepted for this contribution PR.

@content-bot
Copy link
Collaborator

For the Reviewer: Successfully created a pipeline in GitLab with url: https://gitlab.xdr.pan.local/xdr/cortex-content/content/-/pipelines/2073254

@content-bot content-bot removed the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Jan 26, 2025
@MLainer1 MLainer1 dismissed idovandijk’s stale review February 4, 2025 07:21

Already approved by label

@MLainer1 MLainer1 merged commit 899c479 into demisto:contrib/CyberInt_feature/sync-indicators Feb 4, 2025
29 checks passed
Copy link

github-actions bot commented Feb 4, 2025

Thank you for your contribution. Your external PR has been merged and the changes are now included in an internal PR for further review. The internal PR will be merged to the master branch within 3 business days.

JudahSchwartz pushed a commit that referenced this pull request Feb 12, 2025
* Add support for IoC Incident Feed (#37021)

* - Fixed mirroring feature
- Added support for IoC Incident Feed
- Added internal identifier of alert to incident fields

* minor fixes

* code fixes according to the review comments

* updated release notes: added information about breaking changes

* update release notes

* update release notes

* update cyberint alerts test

* code refactoring

* code refactoring

* improve tests

* improve tests

* improve tests

* improve tests

* fix commit details

* fix commit

* fix commit

* fix commit

* fix commit

* fix commit

* fix commit

* fix commit

* fix commit

* fix commit

* fix commit

* fix commit

* fix commit

* fix pre-commit

* fix pre-commit

* fix pre-commit

* fix pre-commit

* fix pre-commit

* fix pre-commit

* fix pre-commit

* fix pre-commit

* fix pre-commit issues

* fix pre-commit issues

* fix pre-commit issues

* fix pre-commit issues

* fix pre-commit issues

* pc

* bc fle

* rn

---------

Co-authored-by: klevitskiy-cyberint <[email protected]>
Co-authored-by: MLainer1 <[email protected]>
Co-authored-by: MLainer1 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved External PR Partner Support Level Indicates that the contribution is for Partner supported pack Partner Partner-Approved pending-contributor The PR is pending the response of its creator pending-demo Demo pending Security Approved If a contribution has been approved for merge by the security team, then this will allow a merge Security Review TIM Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants