Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for IoC Incident Feed #37021

Open
wants to merge 8 commits into
base: contrib/CyberInt_feature/sync-indicators
Choose a base branch
from

Conversation

klevitskiy-cyberint
Copy link

@klevitskiy-cyberint klevitskiy-cyberint commented Nov 1, 2024

  • Fixed mirroring feature
  • Added internal identifier of alert to incident fields

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

A few sentences describing the overall goals of the pull request's commits.

Must have

  • Tests
  • Documentation

Screen-Recording-2024-10-31-at-10 25 10

Screen Recording 2024-11-22 at 12 12 05 (1)

- Added support for IoC Incident Feed
- Added internal identifier of alert to incident fields
@content-bot content-bot added Contribution Thank you! Contributions are always welcome! External PR Partner Support Level Indicates that the contribution is for Partner supported pack labels Nov 1, 2024
@content-bot content-bot changed the base branch from master to contrib/CyberInt_feature/sync-indicators November 1, 2024 22:32
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @yaakovpraisler will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

@content-bot
Copy link
Collaborator

Hi @klevitskiy-cyberint, thanks for contributing to the XSOAR marketplace. To receive credit for your generous contribution please follow this link.

@edik24 edik24 self-assigned this Nov 4, 2024
@content-bot content-bot added Partner-Approved Contribution Form Filled Whether contribution form filled or not. Partner labels Nov 4, 2024
@yaakovpraisler yaakovpraisler requested review from samuelFain and removed request for yaakovpraisler November 17, 2024 08:04
@samuelFain
Copy link
Contributor

Hi @klevitskiy-cyberint, we apologize for the delay in reviewing this PR.
A developer from our team will review it as soon as possible. We appreciate your patience.

@klevitskiy-cyberint
Copy link
Author

Hi @samuelFain, thank you for the update and for keeping us informed. We really appreciate your team's effort and understand that reviews can take time.
That said, our mutual client has inquired about the progress of this PR, and I was wondering if it would be possible to share an estimated timeline for the review? This will help us better align expectations on our side.
Thanks again for your support, and please let me know if there’s anything I can do to assist in expediting the process.

@samuelFain samuelFain assigned MLainer1 and unassigned samuelFain Nov 18, 2024
@samuelFain samuelFain removed their request for review November 18, 2024 13:01
@MLainer1
Copy link
Contributor

Hi @klevitskiy-cyberint, thank you for your contribution.
I can see several pre-commit errors on your PR, make sure to run the command demisto-sdk pre-commit to fix those.
I'll update this PR with a code review when it will be ready.

Copy link
Contributor

@MLainer1 MLainer1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! please look at the following notes. Feel ree to contact me for any questions.

Packs/Cyberint/Integrations/Cyberint/Cyberint.py Outdated Show resolved Hide resolved
Packs/Cyberint/Integrations/FeedCyberint/FeedCyberint.py Outdated Show resolved Hide resolved
Packs/Cyberint/Integrations/FeedCyberint/FeedCyberint.py Outdated Show resolved Hide resolved
Packs/Cyberint/Integrations/FeedCyberint/FeedCyberint.py Outdated Show resolved Hide resolved
Packs/Cyberint/Integrations/FeedCyberint/FeedCyberint.py Outdated Show resolved Hide resolved
Packs/Cyberint/Integrations/FeedCyberint/FeedCyberint.py Outdated Show resolved Hide resolved
Packs/Cyberint/Integrations/FeedCyberint/FeedCyberint.py Outdated Show resolved Hide resolved
Packs/Cyberint/Integrations/FeedCyberint/FeedCyberint.py Outdated Show resolved Hide resolved
@MLainer1 MLainer1 added the pending-contributor The PR is pending the response of its creator label Nov 20, 2024
@klevitskiy-cyberint
Copy link
Author

@MLainer1 Thank you for taking the time to thoroughly review the code and for your feedback! I really appreciate the effort you put into providing detailed suggestions.

I’ve reviewed all your comments carefully and prepared code fixes accordingly. Please let me know if there’s anything else you’d like me to adjust or if further refinements are needed.

Thanks again for your support and collaboration! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! External PR Partner Support Level Indicates that the contribution is for Partner supported pack Partner Partner-Approved pending-contributor The PR is pending the response of its creator Security Review TIM Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants