Bug fix/XSUP-43864/FireEye NX fixed fetch incidents #37263
+67
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MosheEichler
added
the
release-notes-only
…hub.com:demisto/content into BugFix/XSUP-43864/FireEye-NX-fix-fetch-incidnts
|
@thefrieddan1 Doc review completed. |
…x-fetch-incidnts # Conflicts: # Packs/FireEyeNX/Integrations/FireEyeNX/FireEyeNX.yml # Packs/FireEyeNX/ReleaseNotes/1_1_34.md
| @@ -25,6 +25,7 @@ | |||
|
|
|||
| DEFAULT_SESSION_TIMEOUT = 15 * 60 # In Seconds | |||
| DEFAULT_FETCH_LIMIT = '50' | |||
| TIME_BACK_IN_SECONDS = 172000.0 # Due to API limitations we can retrieve events only from the last 48 hours. | |||
There was a problem hiding this comment.
change constant name to FORTY_EIGHT_HOURS_IN_SECOND
or keep the name and do TIME_BACK_IN_SECONDS = 60 * 60 * 48
thefrieddan1
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Related Issues
fixes: https://jira-dc.paloaltonetworks.com/browse/XSUP-43864
Description
Updated the start time (used in the fetch-incidents command) to be later than 48 hours ago.
Must have