Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance ms teams functionalities part1 #37268

Merged
merged 50 commits into from
Dec 1, 2024

Conversation

ShacharKidor
Copy link
Contributor

@ShacharKidor ShacharKidor commented Nov 18, 2024

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

relates: CIAC-11459

Description

  1. Added the'microsoft-teams-token-permissions-list'command which retrieves the API permissions list of the graph access token.
  2. Added the 'microsoft-teams-create-messaging-endpoint' command which generates the correct messaging endpoint, based on the server URL and the instance configurations.

Must have

  • Tests
  • Documentation

Copy link

github-actions bot commented Nov 18, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/MicrosoftTeams/Integrations/MicrosoftTeams
   MicrosoftTeams.py136936773%118, 124, 188, 190, 212–213, 243, 252, 254, 282–283, 285–288, 290–293, 297, 315, 319, 327–328, 576–577, 608, 653–657, 659–660, 687–688, 701–702, 709–713, 731, 741–746, 748–749, 751–752, 762–763, 779–780, 818–819, 832–835, 837–839, 841–843, 845, 854–855, 859–860, 888, 904–911, 913–917, 919–921, 923–925, 928–931, 933, 935–952, 954, 956–957, 960–963, 965, 967–968, 970–973, 975–976, 978, 983, 985–989, 991–993, 1088–1091, 1099–1102, 1104–1106, 1108–1111, 1113, 1115, 1254, 1256, 1374–1375, 1438, 1510, 1513–1515, 1517–1518, 1520–1521, 1523, 1542, 1547, 1549, 1820–1821, 1906–1909, 2031, 2101, 2110, 2165–2166, 2173, 2192–2193, 2196, 2275–2282, 2284–2290, 2295–2296, 2298–2307, 2311–2314, 2316, 2346, 2354, 2369, 2393–2394, 2397, 2454, 2458, 2476, 2493–2495, 2514, 2560–2561, 2569–2572, 2574–2575, 2577–2583, 2585–2587, 2589–2592, 2594, 2597–2598, 2600, 2602–2605, 2607, 2609–2616, 2618–2627, 2631, 2644–2645, 2648–2652, 2654–2657, 2659, 2694, 2696, 2717–2719, 2721–2722, 2724, 2726–2727, 2729–2730, 2732–2734, 2736, 2738–2742, 2744–2747, 2749–2751, 2753, 2755, 2757–2767, 2769–2775, 2840, 2853, 2895–2898, 2900–2901, 2904, 2912–2913, 2924–2927, 2931–2932, 2938, 2960
TOTAL136936773% 

Tests Skipped Failures Errors Time
113 0 💤 0 ❌ 0 🔥 3.492s ⏱️

Copy link
Contributor

@michal-dagan michal-dagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!!

Copy link
Contributor

@merit-maita merit-maita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!

Copy link
Contributor

@jbabazadeh jbabazadeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • MicrosoftTeams pack version was bumped to 1.5.7.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@ShacharKidor ShacharKidor added ForceMerge Forcing the merge of the PR despite the build status and removed ForceMerge Forcing the merge of the PR despite the build status labels Dec 1, 2024
@ShacharKidor ShacharKidor merged commit c6c7165 into master Dec 1, 2024
21 checks passed
@ShacharKidor ShacharKidor deleted the enhance_ms_teams_functionalities_part1 branch December 1, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants