NetQuest OMX Pack + Integration #37319

rshunim · 2024-11-20T12:36:29Z

Status

In Progress
Ready
In Hold - (Reason for hold)

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-11634

Description

A new pack with new integration which contains 5 commands and event collector for XSIAM.

Must have

Tests
Documentation

…etQuest_OMX_Integration

github-actions · 2024-11-20T12:42:34Z

Coverage Report

File	Stmts	Miss	Cover	Missing
Packs/NetQuestOMX/Integrations/NetQuestOMX
NetQuestOMX.py	192	67	65%	67–68, 113–114, 124–125, 137–138, 149–150, 161–162, 173–174, 189–190, 205–206, 221–222, 256–257, 289–290, 311–312, 331–332, 354, 357–361, 364–365, 376–378, 450–454, 456, 458, 460, 467, 476, 478, 480–481, 483–484, 491–492, 494, 496–497, 499, 506–508, 511, 514–516
TOTAL	192	67	65%

Tests	Skipped	Failures	Errors	Time
40	0 💤	0 ❌	0 🔥	9.122s ⏱️

dorschw

nice

Packs/NetQuestOMX/Integrations/NetQuestOMX/NetQuestOMX.py

Co-authored-by: dorschw <[email protected]>

…etQuest_OMX_Integration

Co-authored-by: dorschw <[email protected]>

…etQuest_OMX_Integration

Co-authored-by: dorschw <[email protected]>

rshunim added 6 commits November 18, 2024 18:09

first commit - yml file integration with parameters

964a179

two commands

7264ab6

add outputs for netquest-address-list-optimize command in the yml file

41a799c

all 5 commands in the yml

6896abc

remove collector and add the client

b1e3421

NetQuest_OMX_Integration with 5 commands

27c920d

rshunim requested a review from dorschw November 20, 2024 12:36

rshunim self-assigned this Nov 20, 2024

rshunim and others added 4 commits November 20, 2024 14:37

delete dummy file

5bd9738

Merge branch 'master' into NetQuest_OMX_Integration

ec28d7e

pre commit

cb2f38e

Merge remote-tracking branch 'origin/NetQuest_OMX_Integration' into N…

339269b

…etQuest_OMX_Integration

dorschw reviewed Nov 20, 2024

View reviewed changes

Packs/NetQuestOMX/Integrations/NetQuestOMX/NetQuestOMX.py Outdated Show resolved Hide resolved

rshunim and others added 13 commits November 20, 2024 16:08

Update Packs/NetQuestOMX/Integrations/NetQuestOMX/NetQuestOMX.py

8448c21

Co-authored-by: dorschw <[email protected]>

remove sending the headers as an arg since it happens implicitly

3ed241a

Path unlink instead of shutil.rmtree

57cd864

Update Packs/NetQuestOMX/Integrations/NetQuestOMX/NetQuestOMX.py

c3e6d0a

Co-authored-by: dorschw <[email protected]>

Update Packs/NetQuestOMX/Integrations/NetQuestOMX/NetQuestOMX.py

e5f9842

Co-authored-by: dorschw <[email protected]>

Update Packs/NetQuestOMX/Integrations/NetQuestOMX/NetQuestOMX.py

80a7096

Co-authored-by: dorschw <[email protected]>

Update Packs/NetQuestOMX/Integrations/NetQuestOMX/NetQuestOMX.py

e8d735f

Co-authored-by: dorschw <[email protected]>

ok_codes=(200,)

7ddd19d

Merge remote-tracking branch 'origin/NetQuest_OMX_Integration' into N…

1e462d7

…etQuest_OMX_Integration

Update Packs/NetQuestOMX/Integrations/NetQuestOMX/NetQuestOMX.py

4f3f287

Co-authored-by: dorschw <[email protected]>

test module without try except

43a6ce6

CR

bede54a

Merge branch 'master' into NetQuest_OMX_Integration

060d0f5

rshunim requested a review from dorschw November 20, 2024 15:07

DO

190ad1b

rshunim and others added 30 commits November 26, 2024 15:24

Update Packs/NetQuestOMX/Integrations/NetQuestOMX/NetQuestOMX.py

e8515fc

Co-authored-by: dorschw <[email protected]>

Update Packs/NetQuestOMX/Integrations/NetQuestOMX/NetQuestOMX.py

557db23

Co-authored-by: dorschw <[email protected]>

Update Packs/NetQuestOMX/Integrations/NetQuestOMX/NetQuestOMX.py

3f7fa2e

Co-authored-by: dorschw <[email protected]>

fix test-module

55c41b9

Merge remote-tracking branch 'origin/NetQuest_OMX_Integration' into N…

b8ac0ca

…etQuest_OMX_Integration

Update Packs/NetQuestOMX/Integrations/NetQuestOMX/NetQuestOMX.py

c47ad87

Co-authored-by: dorschw <[email protected]>

Update Packs/NetQuestOMX/Integrations/NetQuestOMX/NetQuestOMX.py

d108ce9

Co-authored-by: dorschw <[email protected]>

Update Packs/NetQuestOMX/Integrations/NetQuestOMX/NetQuestOMX.py

2c9009c

Co-authored-by: dorschw <[email protected]>

Update Packs/NetQuestOMX/Integrations/NetQuestOMX/NetQuestOMX.yml

fe906ee

Co-authored-by: dorschw <[email protected]>

temp

0e9ff28

fix UTs

85d73b0

add return-value type

756b818

Merge branch 'master' into NetQuest_OMX_Integration

0652a61

pre commit

2f4fe8c

Update Packs/NetQuestOMX/Integrations/NetQuestOMX/NetQuestOMX.yml

bc6d69b

Co-authored-by: dorschw <[email protected]>

Update Packs/NetQuestOMX/Integrations/NetQuestOMX/NetQuestOMX.yml

e68de74

Co-authored-by: dorschw <[email protected]>

Update Packs/NetQuestOMX/Integrations/NetQuestOMX/NetQuestOMX.yml

b662f3f

Co-authored-by: dorschw <[email protected]>

Merge branch 'master' into NetQuest_OMX_Integration

baf23c4

Edit UT

2bd384d

Edit README.md

ddcdb0c

edit additionalinfo

94df6d2

remove Author_image.png

966eb24

add a comment

09c1ac5

fix UTs

04a3539

edit yml file

9e6aa31

yml

c5f34dd

tempfile replace shutil

a973d99

Enum

577c620

type hints

6e8b295

Pack's README.md

cc5132a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NetQuest OMX Pack + Integration #37319

NetQuest OMX Pack + Integration #37319

rshunim commented Nov 20, 2024

github-actions bot commented Nov 20, 2024 •

edited

Loading

dorschw left a comment

NetQuest OMX Pack + Integration #37319

Are you sure you want to change the base?

NetQuest OMX Pack + Integration #37319

Conversation

rshunim commented Nov 20, 2024

Status

Related Issues

Description

Must have

github-actions bot commented Nov 20, 2024 • edited Loading

dorschw left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 20, 2024 •

edited

Loading