Add a check for Security Approved for contributions #37329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amshamah419
added
Security Approved
RotemAmit
requested changes
Nov 21, 2024
Co-authored-by: RotemAmit <[email protected]>
Co-authored-by: RotemAmit <[email protected]>
|
Here's the testing PR - #37337 |
RotemAmit
reviewed
Nov 21, 2024
Co-authored-by: RotemAmit <[email protected]>
RotemAmit
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Related Issues
fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-12235
Description
If a contributor has opened a PR which requires the Security team to review it, then the merge should be blocked until they have reviewed the PR. This check will block a merge only if the PR is from a contribution and only if the "Security Review" label has been added.
Must have