update: octoxlabs integration #37676

ogulcanhero · 2024-12-13T13:49:37Z

Status

In Progress
Ready
In Hold - (Reason for hold)

Description

Octox Labs Cyber Security Asset Management platform XSoar Integration update.

Minimum version of Cortex XSOAR

Must have

Tests
Documentation

CLAassistant · 2024-12-13T13:49:45Z

All committers have signed the CLA.

content-bot · 2024-12-13T13:51:21Z

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @MLainer1 will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

content-bot · 2024-12-13T13:51:23Z

Hi @ogulcanhero, thanks for contributing to the XSOAR marketplace. To receive credit for your generous contribution please follow this link.

MLainer1

Thank you for your contribution.
A few notes:

Make sure to add a human readable output for every command.
Add tests for the new commands.

Let me know if you need any help/

MLainer1 · 2024-12-15T12:09:10Z

Packs/OctoxLabs/Integrations/OctoxLabs/OctoxLabs.yml

+        description: 'Specific Scroll Id'
+        type: String
+      - contextPath: OctoxLabs.ScrolledApplications.results
+        description: 'List<Dict> Application information.'


Suggested change

description: 'List<Dict> Application information.'

description: 'List Application information.'

MLainer1 · 2024-12-15T12:10:11Z

Packs/OctoxLabs/Integrations/OctoxLabs/OctoxLabs.py

@@ -43,6 +50,10 @@ def run_command(
        "octoxlabs-get-user-by-username": get_user_by_username,
        "octoxlabs-get-groups": get_groups,
        "octoxlabs-get-permissions": get_permissions,
+        "octoxlabs-search-scroll-devices": search_scroll_devices,
+        "octoxlabs-search-scroll-users-inventory": search_scroll_users,


This command is missing from the .yml file

MLainer1 · 2024-12-15T12:11:34Z

Packs/OctoxLabs/Integrations/OctoxLabs/OctoxLabs.yml

+        description: 'Specific Scroll Id'
+        type: String
+      - contextPath: OctoxLabs.ScrolledDevices.results
+        description: 'List<Dict> Device information.'


Suggested change

description: 'List<Dict> Device information.'

description: 'List Device information.'

MLainer1 · 2024-12-15T12:17:44Z

Packs/OctoxLabs/Integrations/OctoxLabs/OctoxLabs.yml

+      - default:
+        description: 'Page.'
+        name: page
+      - default:


In the code it looks like there is a default size: 50. It is better to add this in the description

MLainer1 · 2024-12-15T12:17:51Z

Packs/OctoxLabs/Integrations/OctoxLabs/OctoxLabs.yml

+        description: 'Fields.'
+        isArray: true
+        name: fields
+      - default:


In the code it looks like there is a default size: 1. It is better to add this in the description

MLainer1 · 2024-12-15T12:19:04Z

Packs/OctoxLabs/Integrations/OctoxLabs/OctoxLabs.yml

+        description: 'Fields.'
+        isArray: true
+        name: fields
+      - default:


In the code it looks like there is a default size: 1. It is better to add this in the description

MLainer1 · 2024-12-15T12:19:10Z

Packs/OctoxLabs/Integrations/OctoxLabs/OctoxLabs.yml

+      - default:
+        description: 'Page.'
+        name: page
+      - default:


In the code it looks like there is a default size: 50. It is better to add this in the description

MLainer1 · 2024-12-15T12:27:00Z

Packs/OctoxLabs/Integrations/OctoxLabs/OctoxLabs.py

@@ -28,7 +30,12 @@ def run_command(
        "octoxlabs-get-discoveries": get_discoveries,
        "octoxlabs-get-last-discovery": get_last_discovery,
        "octoxlabs-search-devices": search_devices,
+        "octoxlabs-search-users-inventory": search_users_inventory,


This command is missing from the .yml file

MLainer1 · 2024-12-15T12:27:18Z

Packs/OctoxLabs/Integrations/OctoxLabs/OctoxLabs.py

+# from Packs.Base.Scripts.CommonServerPython.CommonServerPython import CommandResults
+


Is it necessary?

MLainer1 · 2024-12-15T12:28:19Z

Packs/OctoxLabs/Integrations/OctoxLabs/OctoxLabs.yml

+- name: https_proxy
+  display: HTTPS Proxy
+  required: false
+  type: 0
+  additionalinfo: Your HTTPS Proxy URL
+- name: no_verify
+  required: false
+  type: 8
+  display: No Verify
+  additionalinfo: Don't Verify SSL
+


Those 2 new parameters are not documented in the release notes

ogulcanhero · 2024-12-16T07:05:31Z

Hi @MLainer1, thank you for your review. I'm having a problem with the demisto-sdk lint command. When I run the code, I get the error lint() got an unexpected keyword argument 'console_log_threshold'. Is this a known bug?

MLainer1 · 2024-12-16T14:51:24Z

Hi @MLainer1, thank you for your review. I'm having a problem with the demisto-sdk lint command. When I run the code, I get the error lint() got an unexpected keyword argument 'console_log_threshold'. Is this a known bug?

Hi @ogulcanhero, it is a known issue, and a fix will be out in the next few days.
You can use the pre-commit command in the mean time.

ogulcanhero · 2024-12-16T18:08:40Z

Hi @MLainer1, I have 2 questions;

Pre-commit is completely passed in my local, I couldn't understand the reason for the error here.
Is there anything I need to do for the Legacy Validate test?

Thank You!

MLainer1 · 2024-12-18T11:05:34Z

Hi @ogulcanhero, are you running the demisto-sdk pre-commit command? Is your demisto-sdk up to date with the latest version?

ogulcanhero · 2024-12-18T19:30:09Z

Hi @MLainer1 ,
Yes, I use demisto-sdk pre-commit and I am sure that demisto-sdk is in the latest version because when I had a problem with lint, the first thing I did was to update demisto-sdk.

MLainer1 · 2024-12-19T10:09:02Z

@ogulcanhero It looks like the pre-commit fails to add a dot at the end of some sentences. I think that adding that manually shouldn't take more than a few minutes.

…labs

ogulcanhero · 2024-12-20T07:06:16Z

Hi @MLainer1,
I think everything is ok. When can you merge.
Thank You!

MLainer1 · 2024-12-22T08:00:25Z

Hi @ogulcanhero, let's schedule a demo to review your changes and make sure everything works as expected. I'll reach out through DFIR to schedule it.

ogulcanhero · 2024-12-30T12:05:40Z

Hi @MLainer1 ,
Thank you for the review. Is it possible for us to make the improvements you mentioned for now in the next version because our customer has been waiting for the features we added for a long time?
Have a nice day!

MLainer1 · 2024-12-30T12:42:08Z

@ogulcanhero Yes, as the code works and my suggestions are for the visibility of the commands (human readable and better error management)

content-bot · 2024-12-30T12:43:54Z

For the Reviewer: Trigger build request has been accepted for this contribution PR.

content-bot · 2024-12-30T12:44:02Z

For the Reviewer: Successfully created a pipeline in GitLab with url: https://gitlab.xdr.pan.local/xdr/cortex-content/content/-/pipelines/1893944

MLainer1 · 2024-12-30T13:34:15Z

@ogulcanhero, is the PR finished on your side?

ogulcanhero · 2024-12-30T16:43:16Z

Yes @MLainer1 , Thank you!

github-actions · 2024-12-31T07:59:24Z

Thank you for your contribution. Your external PR has been merged and the changes are now included in an internal PR for further review. The internal PR will be merged to the master branch within 3 business days.

* initial: scroll * add: new commands * add: tests and fix docs and typo func names * fix: version number * fix: pre-commit problems * add: new tests for coverage * fix: yml file descriptions * fix: yml file descriptions-2 --------- Co-authored-by: ogulcanhero <[email protected]> Co-authored-by: ahmet kotan <[email protected]>

ogulcanhero added 2 commits December 13, 2024 16:40

initial: scroll

69e10d1

add: new commands

f5280b5

content-bot added Contribution Thank you! Contributions are always welcome! External PR Partner Support Level Indicates that the contribution is for Partner supported pack labels Dec 13, 2024

content-bot changed the base branch from master to contrib/ogulcanhero_octoxlabs December 13, 2024 13:51

content-bot assigned MLainer1 Dec 13, 2024

content-bot requested a review from MLainer1 December 13, 2024 13:51

Shellyber assigned kgal-pan Dec 13, 2024

Shellyber added Partner-Approved Contribution Form Filled Whether contribution form filled or not. Partner labels Dec 13, 2024

MLainer1 requested changes Dec 15, 2024

View reviewed changes

MLainer1 added pending-demo Demo pending pending-contributor The PR is pending the response of its creator and removed pending-demo Demo pending labels Dec 15, 2024

ogulcanhero added 3 commits December 16, 2024 15:42

add: tests and fix docs and typo func names

b03dc58

fix: version number

9b31ff6

fix: pre-commit problems

a9c703a

add: new tests for coverage

40c677e

Merge branch 'contrib/ogulcanhero_octoxlabs' into octoxlabs

9c075c7

ogulcanhero and others added 4 commits December 20, 2024 00:04

fix: yml file descriptions

358f06f

Merge branch 'octoxlabs' of github.com:ogulcanhero/content into octox…

5fe2ea8

…labs

fix: yml file descriptions-2

eba9efb

Merge branch 'contrib/ogulcanhero_octoxlabs' into octoxlabs

67b6c87

MLainer1 added the pending-demo Demo pending label Dec 22, 2024

MLainer1 added post-demo and removed pending-demo Demo pending labels Dec 30, 2024

MLainer1 added the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Dec 30, 2024

content-bot removed the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Dec 30, 2024

MLainer1 added the docs-approved label Dec 30, 2024

MLainer1 self-requested a review December 31, 2024 07:57

MLainer1 approved these changes Dec 31, 2024

View reviewed changes

MLainer1 merged commit 375fcf7 into demisto:contrib/ogulcanhero_octoxlabs Dec 31, 2024
32 checks passed

content-bot mentioned this pull request Dec 31, 2024

update: octoxlabs integration #37877

Merged

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update: octoxlabs integration #37676

update: octoxlabs integration #37676

ogulcanhero commented Dec 13, 2024

CLAassistant commented Dec 13, 2024 •

edited

Loading

content-bot commented Dec 13, 2024

content-bot commented Dec 13, 2024

MLainer1 left a comment

MLainer1 Dec 15, 2024

MLainer1 Dec 15, 2024

MLainer1 Dec 15, 2024

MLainer1 Dec 15, 2024

MLainer1 Dec 15, 2024

MLainer1 Dec 15, 2024

MLainer1 Dec 15, 2024

MLainer1 Dec 15, 2024

MLainer1 Dec 15, 2024

MLainer1 Dec 15, 2024

ogulcanhero commented Dec 16, 2024

MLainer1 commented Dec 16, 2024

ogulcanhero commented Dec 16, 2024

MLainer1 commented Dec 18, 2024

ogulcanhero commented Dec 18, 2024

MLainer1 commented Dec 19, 2024

ogulcanhero commented Dec 20, 2024

MLainer1 commented Dec 22, 2024 •

edited

Loading

ogulcanhero commented Dec 30, 2024

MLainer1 commented Dec 30, 2024

content-bot commented Dec 30, 2024

content-bot commented Dec 30, 2024

MLainer1 commented Dec 30, 2024

ogulcanhero commented Dec 30, 2024

github-actions bot commented Dec 31, 2024

	description: 'List<Dict> Application information.'
	description: 'List Application information.'

	description: 'List<Dict> Device information.'
	description: 'List Device information.'

		# from Packs.Base.Scripts.CommonServerPython.CommonServerPython import CommandResults

update: octoxlabs integration #37676

update: octoxlabs integration #37676

Conversation

ogulcanhero commented Dec 13, 2024

Status

Description

Minimum version of Cortex XSOAR

Must have

CLAassistant commented Dec 13, 2024 • edited Loading

content-bot commented Dec 13, 2024

content-bot commented Dec 13, 2024

MLainer1 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ogulcanhero commented Dec 16, 2024

MLainer1 commented Dec 16, 2024

ogulcanhero commented Dec 16, 2024

MLainer1 commented Dec 18, 2024

ogulcanhero commented Dec 18, 2024

MLainer1 commented Dec 19, 2024

ogulcanhero commented Dec 20, 2024

MLainer1 commented Dec 22, 2024 • edited Loading

ogulcanhero commented Dec 30, 2024

MLainer1 commented Dec 30, 2024

content-bot commented Dec 30, 2024

content-bot commented Dec 30, 2024

MLainer1 commented Dec 30, 2024

ogulcanhero commented Dec 30, 2024

github-actions bot commented Dec 31, 2024

CLAassistant commented Dec 13, 2024 •

edited

Loading

MLainer1 commented Dec 22, 2024 •

edited

Loading