-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pyzipper to py3-tools docker file #26504
Conversation
add import to verify.py |
Docker Image Ready - DevDocker automatic build at CircleCI has deployed your docker image: devdemisto/py3-tools:1.0.0.94142
Docker Metadata
|
Docker Image Ready - DevDocker automatic build at CircleCI has deployed your docker image: devdemisto/py3-native:8.6.0.94144
Docker Metadata
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets also ignore the old versions of the native image for the integration in content, then we can add the label
docker/py3-native/pyproject.toml
Outdated
@@ -81,6 +81,7 @@ pychrome = "*" | |||
openpyxl = "^3.1.2" | |||
python-pptx = "^0.6.23" | |||
ntlm-auth = "^1.5.0" | |||
pyzipper = "*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move to py3-tools-ubi
docker/py3-native/verify.py
Outdated
@@ -13,3 +13,5 @@ | |||
|
|||
import pdf2image | |||
print(f'Using poppler version: {pdf2image.pdf2image._get_poppler_version("pdftocairo")}') | |||
|
|||
import pyzipper |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we dont need this since it imports py3tools ' verify py. lets remove
Docker Image Ready - DevDocker automatic build at CircleCI has deployed your docker image: devdemisto/py3-native:8.6.0.94211
Docker Metadata
|
Docker Image Ready - DevDocker automatic build at CircleCI has deployed your docker image: devdemisto/py3-tools:1.0.0.94213
Docker Metadata
|
Docker Image Ready - DevDocker automatic build at CircleCI has deployed your docker image: devdemisto/py3-tools-ubi:1.0.0.94213
Docker Metadata
|
Docker Image Ready - ProductionDocker automatic build at CircleCI has deployed your docker image: demisto/py3-tools:1.0.0.94214
Docker Metadata
|
Docker Image Ready - ProductionDocker automatic build at CircleCI has deployed your docker image: demisto/py3-tools-ubi:1.0.0.94214
Docker Metadata
|
Status
Ready/In Progress/In Hold (Reason for hold)
Related Content Pull Request
Related PR: https://jira-dc.paloaltonetworks.com/browse/CIAC-10361
Related Issues
Related: link to the issue
Description
Add pyzipper library to py3-tools due to an issue