Skip to content

Commit

Permalink
Merge pull request scandipwa#5232 from AleksandrsKondratjevs/ts-issue…
Browse files Browse the repository at this point in the history
…-ensure-redux-version

TypeScript-issue - Ensure react-redux dependency is added to theme generation
  • Loading branch information
AleksandrsKondratjevs authored Oct 17, 2022
2 parents b361a5d + 1e9166e commit 32f5271
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
2 changes: 2 additions & 0 deletions build-packages/csa-generator-theme/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,7 @@ const run = async (options) => {
let tsServerPluginVersion = '0.0.0';
const postcssVersion = '8.4.5';
const reactTypesVersion = '18.0.17';
const reactReduxVersion = '8.0.2';

try {
scandipwaVersion = await getLatestVersion('@scandipwa/scandipwa');
Expand Down Expand Up @@ -197,6 +198,7 @@ const run = async (options) => {
mosaicCracoVersion,
postcssVersion,
reactTypesVersion,
reactReduxVersion,
proxy: DEFAULT_PROXY,
eslintConfigVersion,
};
Expand Down
3 changes: 2 additions & 1 deletion build-packages/csa-generator-theme/template/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,9 @@
"@scandipwa/ts-server-plugin": "<%= tsServerPluginVersion %>",
"@tilework/mosaic": "<%= mosaicVersion %>",
"@tilework/mosaic-craco": "<%= mosaicCracoVersion %>",
"@types/react": "<%= reactTypesVersion %>",
"postcss": "<%= postcssVersion %>",
"@types/react": "<%= reactTypesVersion %>"
"react-redux": "<%= reactReduxVersion %>"
},
"scandipwa": {
"type": "theme",
Expand Down

0 comments on commit 32f5271

Please sign in to comment.