Merge pull request scandipwa#5264 from AleksandrsKondratjevs/issue-5257

Fix min/max qty for adding product into cart
denisprotassoff · Oct 30, 2022 · 6e3fcec · 6e3fcec
2 parents 9e8ded3 + 1d5daf2
commit 6e3fcec
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 3 deletions.
diff --git a/...ges/scandipwa/src/component/FieldNumberWithControls/FieldNumberWithControls.container.tsx b/...ges/scandipwa/src/component/FieldNumberWithControls/FieldNumberWithControls.container.tsx
@@ -59,7 +59,7 @@ FieldNumberWitControlsContainerState
             this.setState({ value: min });
         }
 
-        if (defaultValue < min) {
+        if (defaultValue < min || prevDefaultValue < min) {
             this.handleInitialLoad(min);
         }
     }

diff --git a/packages/scandipwa/src/component/Notification/Notification.component.tsx b/packages/scandipwa/src/component/Notification/Notification.component.tsx
@@ -42,6 +42,10 @@ export class NotificationComponent extends PureComponent<NotificationComponentPr
 
     CSSHideTimeout: ReturnType<typeof setTimeout> = setTimeout(noopFn);
 
+    __construct() {
+        this.hideNotification = this.hideNotification.bind(this);
+    }
+
     componentDidMount(): void {
         const { notification: { msgType }, lifeTime } = this.props;
 

diff --git a/packages/scandipwa/src/store/Cart/Cart.dispatcher.ts b/packages/scandipwa/src/store/Cart/Cart.dispatcher.ts
@@ -239,7 +239,7 @@ export class CartDispatcher {
                     dispatch(showNotification(NotificationType.ERROR, getErrorMessage(error)));
                 });
 
-                return await Promise.reject();
+                return await Promise.resolve();
             }
 
             await this.updateInitialCartData(dispatch);

diff --git a/packages/scandipwa/src/util/Validator/Validator.ts b/packages/scandipwa/src/util/Validator/Validator.ts
@@ -83,7 +83,7 @@ export const validate = (value: string | boolean, rule: ValidationRule): boolean
     //#region RANGE
     if (range) {
         const { min, max, showLengthError } = range;
-        const isNumber = !!(inputType && inputType in ValidationInputTypeNumber);
+        const isNumber = !!(inputType && (<any>Object).values(ValidationInputTypeNumber).includes(inputType));
 
         if (isNumber) {
             if (min && +value < min) {