Merge pull request scandipwa#5275 from AleksandrsKondratjevs/issue-5254

issue-5254 - Fix popup jumping on opening
denisprotassoff · Nov 3, 2022 · b5fdd25 · b5fdd25
2 parents ae3b702 + 4b0b5fc
commit b5fdd25
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/packages/scandipwa/src/component/Overlay/Overlay.component.tsx b/packages/scandipwa/src/component/Overlay/Overlay.component.tsx
@@ -35,7 +35,7 @@ export class OverlayComponent<P extends OverlayComponentProps = OverlayComponent
 
     overlayRef = createRef<HTMLDivElement>();
 
-    YoffsetWhenScrollDisabled = window.pageYOffset || document.body.scrollTop;
+    YoffsetWhenScrollDisabled = 0;
 
     componentDidUpdate(prevProps: P): void {
         const prevWasVisible = this.getIsVisible(prevProps);
@@ -91,6 +91,7 @@ export class OverlayComponent<P extends OverlayComponentProps = OverlayComponent
     }
 
     freezeScroll(): void {
+        this.YoffsetWhenScrollDisabled = window.pageYOffset || document.body.scrollTop;
         toggleScroll(false);
         document.body.style.marginTop = `${-this.YoffsetWhenScrollDisabled}px`;
     }