Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): remove unsafe in OpsTracker #15025

Merged
merged 1 commit into from
Jun 30, 2022
Merged

fix(core): remove unsafe in OpsTracker #15025

merged 1 commit into from
Jun 30, 2022

Conversation

Nugine
Copy link
Contributor

@Nugine Nugine commented Jun 30, 2022 •
edited
Loading

The current OpsTracker is unsound. It may violate the alias rules of rust reference type. Therefore the SAFETY comments are wrong.

This commit removes all unsafe usages in core/ops_metrics.rs.

Related:

@aapoalas
Copy link
Collaborator

Nice.

lucacasonato
lucacasonato reviewed Jun 30, 2022
View reviewed changes
core/ops_metrics.rs Outdated Show resolved Hide resolved
@lucacasonato lucacasonato requested a review from littledivy June 30, 2022 20:18
bartlomieju
bartlomieju approved these changes Jun 30, 2022
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, seems reasonable

@bartlomieju bartlomieju merged commit a27acbc into denoland:main Jun 30, 2022
dsherret pushed a commit that referenced this pull request Jul 5, 2022
@Nugine @dsherret
fix(core): remove unsafe in OpsTracker (#15025)
7c17141
@Nugine Nugine deleted the pr-ops-metrics branch October 6, 2022 18:18
@Nugine Nugine mentioned this pull request Oct 7, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato left review comments

@bartlomieju bartlomieju bartlomieju approved these changes

@littledivy littledivy Awaiting requested review from littledivy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Nugine @aapoalas @lucacasonato @bartlomieju