Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: key on request destination #58

Closed
wants to merge 35 commits into from

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Aug 23, 2024

This is for Deno 2.0. We need to slightly break the cache and key on the request destination in addition to the specifier.

This is to better support import attributes. For example, scenarios like the following couldn't be represented in the cache until now:

import value from "https://example.com/data";
import value from "https://example.com/data" with { type: "json" };

In Deno itself, we're going to error for scenarios like this, but we need to allow multiple programs to use scenarios like this independently.

Waiting on:

  • Deno graph changes to support this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant