Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: export all symbols for Wasm modules #977

Merged
merged 1 commit into from
Nov 21, 2024
Merged

fix: export all symbols for Wasm modules #977

merged 1 commit into from
Nov 21, 2024

Conversation

bartlomieju
Copy link
Member

Closes #974

@bartlomieju
Copy link
Member Author

@dsherret will there be any changes required to type checking for table, memory and global to be supported?

@bartlomieju
Copy link
Member Author

Integrated in Deno:
Screenshot 2024-11-21 at 20 46 14

@bartlomieju bartlomieju enabled auto-merge (squash) November 21, 2024 19:47
@dsherret
Copy link
Member

will there be any changes required to type checking for table, memory and global to be supported?

No, it's already handled there.

dsherret
dsherret approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dsherret dsherret enabled auto-merge (squash) November 21, 2024 20:16
@dsherret dsherret merged commit a5bfca9 into denoland:main Nov 21, 2024
18 checks passed
@bartlomieju bartlomieju deleted the wasm_export_all_symbols branch November 21, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wasm module only exports functions
2 participants
@bartlomieju @dsherret