Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented seek and seekSync #189

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Implemented seek and seekSync #189

wants to merge 1 commit into from

Conversation

AlexanderOMara
Copy link

@AlexanderOMara AlexanderOMara commented Nov 7, 2024 •
edited
Loading

Since there's no way in Node to seek/tell the current position (when position is null), track the position internally and use that instead.

Solves #142 .

@CLAassistant
Copy link

CLAassistant commented Nov 7, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@AlexanderOMara AlexanderOMara force-pushed the shim-deno-seek branch 2 times, most recently from f523a5e to 5f84482 Compare November 7, 2024 04:15
@AlexanderOMara AlexanderOMara mentioned this pull request Nov 7, 2024
Open
@AlexanderOMara AlexanderOMara force-pushed the shim-deno-seek branch 8 times, most recently from 0e1504d to 718d5ab Compare November 8, 2024 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexanderOMara @CLAassistant