-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
suggestion: rework std/log
to use Streams API
#3907
Comments
I'm having a go at this. It looks like moving to the Streams API causes some of the handler methods to become async, this might introduce complexities around what happens if a log comes in mid flush as operations are no longer atomic, especially so for the Would you mind if I submit a WIP PR to see if I'm on the right track? I might need to implement a queue to buffer the buffer. |
That's great to hear! I've looked at your PR, and it seems like you're on the right track for now. Please let us know if you have any questions. |
std/log
is the last of the sub-modules that uses the deprecatedWriter
(i.e.Deno.Writer
) interface. It should useWritableStream
instead.Related:
Deno.Reader
,Deno.ReaderSync
,Deno.Writer
,Deno.WriterSync
andDeno.Closer
deno#21465The text was updated successfully, but these errors were encountered: