prevent scroll on va-number-input from updating value when input is focused #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it-harrison
changed the title
jamigibbs
reviewed
Aug 17, 2023
| @@ -211,6 +219,7 @@ export class VaNumberInput { | |||
| required={required || null} | |||
| onInput={handleInput} | |||
| onBlur={handleBlur} | |||
| onWheel={handleWheel} | |||
There was a problem hiding this comment.
Did this more organic solution not work?
from
<input type="number">to<input type="text" inputmode="numeric" pattern="[0-9]*">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chromatic
https://1989-va-number-input-scroll-bug--60f9b557105290003b387cd5.chromatic.com
Description
This PR prevents the value on the component from incrementing when the user scrolls on the input while the input is in focus.
Closes 1989
Testing done
local testing in chrome, edge, safari, firefox
Screenshots
Screen.Recording.2023-08-17.at.12.47.42.PM.mov
Acceptance criteria
Definition of done