Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug/10222-rachael-detox-fix-nightly-errors #10244

Merged
merged 1 commit into from
Dec 2, 2024
Merged

bug/10222-rachael-detox-fix-nightly-errors #10244

merged 1 commit into from
Dec 2, 2024

Conversation

rbontrager
Copy link
Contributor

@rbontrager rbontrager commented Nov 22, 2024 •
edited by TKDickson
Loading

Description of Change

Fix nightly detox errors in navigation (The claims files requests flow got changed so its no longer showing the bottom nav bar. The navigation tests require the bottom nav bar to works) and added safeguards so the tests will still sign in even if the sign in button is off the screen.

Passing android here
Passing ios (minus claims which wasn't touched) [here] 9https://github.com/department-of-veterans-affairs/va-mobile-app/actions/runs/11975414509/job/33388840604)

Screenshots/Video

Testing

  • Tested on iOS
  • Tested on Android

Reviewer Validations

PR Checklist

Reviewer: Confirm the items below as you review

  • PR is connected to issue(s)
  • Tests are included to cover this change (when possible)
  • No magic strings (All string unions follow the Union -> Constant type pattern)
  • No secrets or API keys are checked in
  • All imports are absolute (no relative imports)
  • New functions and Redux work have proper TSDoc annotations

For QA

Run a build for this branch

@rbontrager rbontrager marked this pull request as ready for review November 22, 2024 18:00
@rbontrager rbontrager requested review from a team as code owners November 22, 2024 18:00
@rbontrager rbontrager merged commit 518b120 into develop Dec 2, 2024
86 of 91 checks passed
@rbontrager rbontrager deleted the bug/10222-rachael-detox-fix-nightly-errors branch December 2, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TKDickson TKDickson TKDickson approved these changes

@timwright12 timwright12 Awaiting requested review from timwright12 timwright12 is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@alexandec alexandec Awaiting requested review from alexandec alexandec is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@theodur theodur Awaiting requested review from theodur theodur is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@dumathane dumathane Awaiting requested review from dumathane dumathane is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@cadibemma cadibemma Awaiting requested review from cadibemma cadibemma is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@Sparowhawk Sparowhawk Awaiting requested review from Sparowhawk Sparowhawk is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@DonMcCaugheyUSDS DonMcCaugheyUSDS Awaiting requested review from DonMcCaugheyUSDS DonMcCaugheyUSDS is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rbontrager @TKDickson