Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug/9268-Binny-PutSettingsOnProfileAlways #10247

Merged
merged 1 commit into from
Nov 29, 2024
Merged

bug/9268-Binny-PutSettingsOnProfileAlways #10247

merged 1 commit into from
Nov 29, 2024

Conversation

dumathane
Copy link
Contributor

Description of Change

Screenshots/Video

Testing

  • Tested on iOS
  • Tested on Android

Reviewer Validations

PR Checklist

Reviewer: Confirm the items below as you review

  • PR is connected to issue(s)
  • Tests are included to cover this change (when possible)
  • No magic strings (All string unions follow the Union -> Constant type pattern)
  • No secrets or API keys are checked in
  • All imports are absolute (no relative imports)
  • New functions and Redux work have proper TSDoc annotations

For QA

Run a build for this branch

@dumathane dumathane requested review from a team as code owners November 22, 2024 16:26
@github-actions github-actions bot added the FE-With QA A PR waiting for QA Activity label Nov 25, 2024
@alexandec
Copy link
Contributor

Any unit or E2E test changes/improvements needed here?

@github-actions github-actions bot added FE-Ready to Merge and removed FE-With QA A PR waiting for QA Activity labels Nov 26, 2024
@dumathane dumathane merged commit 1c8150b into develop Nov 29, 2024
57 of 58 checks passed
@dumathane dumathane deleted the bug/9268-Binny-PutSettingsOnProfileAlways branch November 29, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandec alexandec alexandec approved these changes

@rbontrager rbontrager rbontrager approved these changes

@timwright12 timwright12 Awaiting requested review from timwright12 timwright12 is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@theodur theodur Awaiting requested review from theodur theodur is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@cadibemma cadibemma Awaiting requested review from cadibemma cadibemma is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@Sparowhawk Sparowhawk Awaiting requested review from Sparowhawk Sparowhawk is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@DonMcCaugheyUSDS DonMcCaugheyUSDS Awaiting requested review from DonMcCaugheyUSDS DonMcCaugheyUSDS is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

Assignees
No one assigned
Labels
FE-Ready to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dumathane @alexandec @rbontrager