Skip to content

Commit

Permalink
Merge remote-tracking branch 'origin/main' into VACMS-19163-Linksfiel…
Browse files Browse the repository at this point in the history
…dSpotlightCLPrequired
  • Loading branch information
jv-agile6 committed Nov 19, 2024
2 parents caf5b3d + 470044c commit f336fca
Show file tree
Hide file tree
Showing 91 changed files with 2,141 additions and 552 deletions.
1 change: 1 addition & 0 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
/config/sync/*full_width_banner_alert* @department-of-veterans-affairs/facilities-cms
# To catch VAMC stuff with older naming convention
/config/sync/*health_care* @department-of-veterans-affairs/facilities-cms
/config/sync/*connect_with_us* @department-of-veterans-affairs/public-websites-cms
/config/sync/*jsonapi* @department-of-veterans-affairs/accelerated-publishing
# aka VAMC System Locations List
/config/sync/*locations_listing* @department-of-veterans-affairs/facilities-cms
Expand Down
20 changes: 11 additions & 9 deletions .github/ISSUE_TEMPLATE/runbook-new-vamc-system.md
Original file line number Diff line number Diff line change
Expand Up @@ -116,12 +116,12 @@ assignees: ''
### Menu configuration and clean up [CMS helpdesk or Sitewide team]
- [ ] Go to [Content / Menus](https://prod.cms.va.gov/admin/structure/menu)
- [ ] Find the relevant menu and select edit menu
- [ ] Ensure all menu links are nested in the proper place
- [ ] Set some menu links to disabled
- [ ] Consult [VAMC sitemap in sharepoint](https://dvagov.sharepoint.com/:x:/s/SitewideContract/EblgAS21OUtHloKK3a8ZvNIBHzV1S6uO2l4hj4dqYG0avQ?e=J8UVZh) for menu settings (Here's a [backup static copy](https://github.com/department-of-veterans-affairs/va.gov-team/blob/1b010e72b992dbefa7305764b0058841131733bc/products/facilities/medical-centers/VAMC-Sitemap.xlsx) in case of access issues in the future)
- [ ] Ensure all menu links are nested in the proper place by opening each menu item individually and ensuring it has the correct parent link, and saving
- [ ] Set some menu links to disabled, according to the [VAMC sitemap in sharepoint](https://dvagov.sharepoint.com/:x:/s/SitewideContract/EblgAS21OUtHloKK3a8ZvNIBHzV1S6uO2l4hj4dqYG0avQ?e=J8UVZh)
- [ ] Consult [VAMC sitemap in sharepoint](https://dvagov.sharepoint.com/:x:/s/SitewideContract/EblgAS21OUtHloKK3a8ZvNIBHzV1S6uO2l4hj4dqYG0avQ?e=J8UVZh) for menu settings (Here's a [backup static copy](https://github.com/department-of-veterans-affairs/va.gov-team/blob/1b010e72b992dbefa7305764b0058841131733bc/products/facilities/medical-centers/VAMC-Sitemap.xlsx) in case of access issues in the future)

### URL alias configuration [CMS helpdesk or Sitewide team]
- [ ] Check that each page has the correct URL alias matching the [VAMC sitemap in sharepoint](https://dvagov.sharepoint.com/:x:/s/SitewideContract/EblgAS21OUtHloKK3a8ZvNIBHzV1S6uO2l4hj4dqYG0avQ?e=J8UVZh)
- [ ] Check that each page has the correct URL alias matching the [VAMC sitemap in sharepoint](https://dvagov.sharepoint.com/:x:/s/SitewideContract/EblgAS21OUtHloKK3a8ZvNIBHzV1S6uO2l4hj4dqYG0avQ?e=J8UVZh), and breadcrumb
- [ ] If pages dont have the correct URL Alias, change them from Auto to Manual and input the correct URL alias

### User set up [CMS helpdesk]
Expand All @@ -132,9 +132,11 @@ assignees: ''
### VAMC editor tasks
- [ ] Complete training if they haven't already
- [ ] Follow the instructions in [VAMC editor guide](https://prod.cms.va.gov/help/vamc)
- [ ] Confirm when ready to publish
- [ ] Advise the Editor not to publish content until all drafts, including Top Task pages, are ready to Publish.
- [ ] Ask the Editor to confirm when they are ready for Helpdesk / Sitewide to publish the site

### Launch tasks
- [ ] Lighthouse coordination for service push?
- [ ] Redirects?
- [ ] Comms, change management?
### Launch tasks [CMS helpdesk or Sitewide team]
- [ ] Bulk publish content in a Tugboat and re-verify URLs, menu items / parents / structure, and breadcrumbs
- [ ] Coordinate timing with Editor for a bulk publish of all ready content in production, including Top Task pages
- [ ] If there is a legacy site for the system, or if existing facilities move into the new system, create a ticket for the appropriate redirects
- [ ] Notify the Editor that the site is published
2 changes: 1 addition & 1 deletion .github/workflows/actions-metrics.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
timeout-minutes: 10
steps:
- name: Send GitHub Actions metrics to DataDog
uses: int128/datadog-actions-metrics@1211003b807510c6a05df26ab9fbc381276a2c1f # v1.100.0
uses: int128/datadog-actions-metrics@68e67870eb6cdaaf74d2a860437fa4e4f0ad2c11 # v1.104.0
with:
datadog-api-key: ${{ secrets.DATADOG_API_KEY }}
collect-job-metrics: true
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/continuous_integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ jobs:
with:
fetch-depth: 0
- name: Delete any existing comment.
uses: thollander/actions-comment-pull-request@e2c37e53a7d2227b61585343765f73a9ca57eda9 # v3.0.0
uses: thollander/actions-comment-pull-request@24bffb9b452ba05a4f3f77933840a6a841d1b32b # v3.0.1
continue-on-error: true
with:
comment_tag: check-composer-lock-changes
Expand All @@ -184,7 +184,7 @@ jobs:
echo "LINES_CHANGED=$LINES_CHANGED" >> $GITHUB_ENV
echo "THRESHOLD=$THRESHOLD" >> $GITHUB_ENV
- name: Comment if composer.lock changes exceed threshold.
uses: thollander/actions-comment-pull-request@e2c37e53a7d2227b61585343765f73a9ca57eda9 # v3.0.0
uses: thollander/actions-comment-pull-request@24bffb9b452ba05a4f3f77933840a6a841d1b32b # v3.0.1
if: env.LINES_CHANGED > env.THRESHOLD
continue-on-error: true
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/cypress.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ jobs:
NODE_TLS_REJECT_UNAUTHORIZED: 0

- name: Cypress run
uses: cypress-io/github-action@0da3c06ed8217b912deea9d8ee69630baed1737e # v6.7.6
uses: cypress-io/github-action@f1f0912d392f0d06bdd01fb9ebe3b3299e5806fb # v6.7.7
with:
wait-on: "${{ inputs.preview_url }}"
command: 'npm run test:cypress:parallel'
Expand Down
7 changes: 4 additions & 3 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -49,14 +49,14 @@
"drupal/consumers": "^1.17.0",
"drupal/content_lock": "^2.3",
"drupal/content_model_documentation": "^1.0.19",
"drupal/content_sync": "^4.0@RC",
"drupal/core-composer-scaffold": "^10.2.0",
"drupal/core-recommended": "^10.2.0",
"drupal/crop": "^2.0",
"drupal/csv_serialization": "^4.0",
"drupal/ctools_block": "^4.0",
"drupal/danse": "^2.2",
"drupal/danse_content_moderation": "^2.0@beta",
"drupal/default_content_deploy": "^2.0",
"drupal/devel_entity_updates": "^4.1",
"drupal/diff": "^1.0",
"drupal/dropzonejs": "^2.0",
Expand Down Expand Up @@ -231,7 +231,7 @@
"symfony/phpunit-bridge": "^5.1",
"symfony/process": "^6.3",
"symfony/routing": "^6.3",
"va-gov/content-build": "^0.0.3627",
"va-gov/content-build": "^0.0.3634",
"vlucas/phpdotenv": "^5.6",
"webflo/drupal-finder": "1.3.1",
"webmozart/path-util": "^2.3",
Expand Down Expand Up @@ -403,7 +403,8 @@
"3241295 - CKEditor 5 isn't respecting field widgets row settings": "patches/3241295-ckeditor-5-not-respecting-field-widgets-row-settings.patch",
"3376267 - [upstream] Add style to anchor leads to unusable behavior": "patches/3376267-add-style-to-anchor-leads-to-unusable-behavior.patch",
"3285657 - The content has either been modified by another user, or you have already submitted modifications error": "patches/3285657-node-lock-translations.patch",
"VACMS-19177 remove username form logging in user module": "patches/VACMS-19177-patch-for-user-module-to-log-uid.patch"
"VACMS-19177 remove username form logging in user module": "patches/VACMS-19177-patch-for-user-module-to-log-uid.patch",
"3082011 - Fix for orphaned label tags": "patches/3082011-19-do-not-use-label-HTML-tag-in-item-form-element.patch"
},
"drupal/danse": {
"3364925 - added explicit access check": "patches/3364925-added-explicit-access-check.patch"
Expand Down
Loading

0 comments on commit f336fca

Please sign in to comment.